Changed dir2pi to use original file name in file link.

[tikank]

As pkg_new_basename was constructed from the normalized package name, it did not always match the original filename. This caused problems with wheels with underscores. Now the original filename (pkg_basename) is used in file link, so the link should match exactly.

I think this change should fix #76 and #84, and is alternative to #67.

I updated also test cases to match this change.

[yjjnls]

pretty good！

[minato7]

Yes, this was much needed, any idea in which version this fix will be available?

[RistoVaaraniemi]

I had to make some ugly local scripting to fix this bug (hopefully temporarily). I hope this project hasn't died.

[longedok]

I'm facing the same issue, would be grate if those changes could be merged in.

[safiyat]

@tikank Sorry for such a late response.

I looked at various PEPs and have concluded that though your code change helps you and others, according to the current standards, all the normalized names contain a hyphen (-) and not an underscore. To quote from the often quoted PEP 503:

This PEP references the concept of a "normalized" project name. As per PEP 426 the only valid characters in a name are the ASCII alphabet, ASCII numbers, ., -, and _. The name should be lowercased with all runs of the characters ., -, or _ replaced with a single - character.

So, the solution you suggested (to use the original filename itself) is not very favorable.

Also, the Python Packaging User Guide suggests that for "Manual" repositories, normalization as defined in PEP 503 should be used.

I am inclined (slightly) to accept this change since it helps so many people, but I will need some good justification for it.

[tikank]

The package name is still normalized, and it is used in top level index.html and in directory name. Only file name is used as is. If wheel file name is normalized using the rules described in PEP 503, it is against wheel specification (see PEP 427), and it causes the bugs.
Also, using unchanged file name matches the behavior of pypi.org, for example https://pypi.org/simple/python-dateutil/ .

[tikank]

Hi there. I am not sure if I can give any more justification for this change. I think that PEP 503 does not say that file names should be normalized:

Below the root URL is another URL for each individual project contained within a repository. The format of this URL is /<project>/ where the <project> is replaced by the normalized name for that project, so a project named "HolyGrail" would have an URL like /holygrail/. This URL must respond with a valid HTML5 page with a single anchor element per file for the project. The text of the anchor tag MUST be the filename of the file and the href attribute MUST be an URL that links to the location of the file for download.

This change does not affect the normalization of the /<project>/ part.

Looking the example from Python Packaging User Guide, the Foo-1.0.tar.gz file name is not either normalized, only the directory name is.

Also as the main use case for the pip2pi is to download packages and form package repository, I think it is safe to assume the file names are already in correct format, and pip2pi should use them without change.

I hope this helps to decide whether the pull request should be accepted or rejected.

[terrdavis]

Thanks @tikank. I'll be using your fork until this pull request is accepted.

[kirkfox]

Is this going to get published to pypi or are we required to clone the repo?

[terrdavis]

I've added the commit archive url: https://github.com/wolever/pip2pi/archive/387105139257cff8a407eaf873c7ee778b4e26ea.zip
to my requirements file.
It's pinned to the merge-commit, so I won't see any further changes.
It would be much appreciated if they published this to pypi though!

[safiyat]

pip2pi 0.8.1 released.