Wrong captured package name when - in name

[fallenwood]

Environment

• pip version: 18.1
• Python version: 2.7.15
• OS: ubuntu 16.04

Description

I am building local cassandra-driver packages using dir2pi, getting a tree like this

# tree dist
dist
├── cassandra_driver-3.14.0-cp27-cp27mu-linux_x86_64.whl
├── cassandra-driver-3.14.0.tar.gz
└── simple
    ├── cassandra-driver
    │   ├── cassandra-driver-3.14.0-cp27-cp27mu-linux_x86_64.whl -> ../../cassandra_driver-3.14.0-cp27-cp27mu-linux_x86_64.whl
    │   ├── cassandra-driver-3.14.0.tar.gz -> ../../cassandra-driver-3.14.0.tar.gz
    │   └── index.html
    └── index.html

Then I want to install the local whl files using pip install --find-links, but pip complain that project name is wrong.
I dig a bit into the code to find that when constructing a Wheel, pip using a regex to find the name

    wheel_file_re = re.compile(
        r"""^(?P<namever>(?P<name>.+?)-(?P<ver>.*?))
        ((-(?P<build>\d[^-]*?))?-(?P<pyver>.+?)-(?P<abi>.+?)-(?P<plat>.+?)
        \.whl|\.dist-info)$""",
        re.VERBOSE
    )

It (the group name) matched cassandra-driver's cassadra but driver dropped, so the project name mismatch.
It used to work at pip 8.0 (yeah we are using pip 8.0, I am updating version of pip), with the regexp

    wheel_file_re = re.compile(
        r"""^(?P<namever>(?P<name>.+?)-(?P<ver>\d.*?))
        ((-(?P<build>\d.*?))?-(?P<pyver>.+?)-(?P<abi>.+?)-(?P<plat>.+?)
        \.whl|\.dist-info)$""",
        re.VERBOSE
    )

which is slightly different, but it works

here is a demo of what the regex will capture

import re

# from latest master
wheel_file_re_latest = re.compile(
    r"""^(?P<namever>(?P<name>.+?)-(?P<ver>.*?))
    ((-(?P<build>\d[^-]*?))?-(?P<pyver>.+?)-(?P<abi>.+?)-(?P<plat>.+?)
    \.whl|\.dist-info)$""",
    re.VERBOSE
)

# from tag 8.0.3
wheel_file_re = re.compile(
    r"""^(?P<namever>(?P<name>.+?)-(?P<ver>\d.*?))
    ((-(?P<build>\d.*?))?-(?P<pyver>.+?)-(?P<abi>.+?)-(?P<plat>.+?)
    \.whl|\.dist-info)$""",
    re.VERBOSE
)

filename = "cassandra-driver-3.14.0-cp27-cp27mu-linux_x86_64.whl"

print(wheel_file_re_latest.match(filename).group('name'))  # cassandra
print(wheel_file_re.match(filename).group('name'))         # cassandra-driver

Found a related commit 283cf2ca78a70f7ff646b8ed173710888bd3dc5f

Expected behavior

The package is installed using local whl files

How to Reproduce

See description above

Output
See description above

[xavfernandez]

Hello and thanks for your issue and careful investigation.

However distribution names in wheel filename should not contain -, cf https://www.python.org/dev/peps/pep-0427/#escaping-and-unicode and thus cassandra-driver-3.14.0-cp27-cp27mu-linux_x86_64.whl is not a valid wheel filename.

Whatever produced it should instead have named it cassandra_driver-3.14.0-cp27-cp27mu-linux_x86_64.whl and should report this issue with them (dir2pi ?).

[fallenwood]

Thank you, I found a related issue under pip2pi

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.