Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt#2: New features, TCX Export Enhancement, unit tests enhancements and fixes #291

Merged
merged 103 commits into from
Jan 21, 2021
Merged

Attempt#2: New features, TCX Export Enhancement, unit tests enhancements and fixes #291

merged 103 commits into from
Jan 21, 2021

Conversation

FJBDev
Copy link
Collaborator

@FJBDev FJBDev commented Jan 20, 2021 •
edited

See original PR that failed to merge and this PR

Unit tests 100%% successful:
image

@FJBDev
Changes per code review
fc27982
@FJBDev
Removing the harmless ResourceNotFoundException
b832400
@FJBDev
Putting it back
c63ee69
@FJBDev
We clear the browser session so that a user can log in with different
f39e032 
accounts
@FJBDev
Misc
d802121
@FJBDev
Useless
360fb27
@FJBDev
Merge remote-tracking branch 'Wolfgang/main' into main
26e7937
@FJBDev
Making the Strava upload asynchronous to speed up the upload
7a41cb4
@FJBDev
Renaming the field per Wolfgang suggestion
c893b98
@FJBDev
Putting fields, which belong together, into { ... }, for better
ce20539 
readability
@FJBDev
displaying the account user name in the upload dialog
7bffbe1
@FJBDev
Misc
6fd934f
@FJBDev
Export Unit tests update and successful
47fc47a
@FJBDev
Unit tests
d9d8639
@FJBDev
Unit tests update after this fix
0035cfe 
20bb310
@FJBDev
XML Unit 2.8.2
86b8882
@FJBDev
Using OauthConstants
3313418
@FJBDev
Merge remote-tracking branch 'Wolfgang/main' into main
9c41791
@FJBDev
Typo
909003c
@FJBDev
Merge remote-tracking branch 'wolfgang/main' into main
7d34a46
@FJBDev
Unit tests update
65173ea
@FJBDev
Dropbox Authentication modifications (Using external browser and PKCE…
1c228e8 
… implementation) (#38)
@FJBDev
Readme update
fc1e6fa
@FJBDev
Misc
c9d50c9
@FJBDev
Merge remote-tracking branch 'wolfgang/main' into main
a60a2cf 
Conflicts:
	info/release-notes/21.next.0-readme.txt
@FJBDev
Adding the number of tours in the progress bar message
7654e68
@FJBDev
Translation typos
a137a05
@FJBDev
Trying to renew the token right before uploading the tours
5c6a6c7
@FJBDev
Default button is now at the bottom of the page
e7b97e1
@FJBDev
Putting constructLocalExpireAtDateTime in TimeTools for reuse
4032e9d
FJBDev and others added 18 commits January 16, 2021 21:25
@FJBDev
Adding source
62e1bb5
@FJBDev
French translation
c70a0ce
@wolfgang-ch
[Tour Chart] Added chart type to draw a graph with dots, this is avai…
fa95e70 
…lable only for "debugging"
@wolfgang-ch
Merge branch 'main' into HRV-RR
8e06b5b
@wolfgang-ch
[HRV-RR] Implementing 2nd pulse graph to display bpm from pulse time
f4bbf58
@FJBDev
Merge remote-tracking branch 'wolfgang/main' into main
f6281db
@FJBDev
Indentation
c7acf09
@FJBDev
Code improvement
e2d7614
@FJBDev
Revert
944b772
@FJBDev
Fixed a bug where the authentication would not work if the browser's
0f1b3ec 
response was too long (in french for example). Fixed the browser's
response for languages with accents
@FJBDev
Using the Http Constant
a6c1b5f
@FJBDev
Using the Http Constant
0d99f8f
@FJBDev
Code improvements
123352d
@wolfgang-ch
[HRV-RR] Implementing 2nd pulse graph to display bpm from pulse time
fe24faf
@FJBDev
putting the export actions into a submenu action
33a7ef8
@FJBDev
Found code to polish when I inspired myself for the export map submenu
42f6d80
@FJBDev
Adding tooltip for the searchtourbylocation
c4bb41b
@wolfgang-ch
[HRV-RR] Implementing 2nd pulse graph to display bpm from pulse time
c11018e
@FJBDev FJBDev mentioned this pull request Jan 20, 2021
Merged
@FJBDev FJBDev changed the title New features and unit tests enhancements New features, TCX Export Enhancement, unit tests enhancements and fixes Jan 20, 2021
@FJBDev
Merge remote-tracking branch 'Wolfgang/main' into main
c12a4e2 
Conflicts:
	info/release-notes/21.next.0-readme.txt
@FJBDev FJBDev changed the title New features, TCX Export Enhancement, unit tests enhancements and fixes Attempt#2: New features, TCX Export Enhancement, unit tests enhancements and fixes Jan 20, 2021
@wolfgang-ch wolfgang-ch merged commit 85864f4 into mytourbook:FJBDev Jan 21, 2021
wolfgang-ch
wolfgang-ch reviewed Jan 21, 2021
View reviewed changes
Copy link
Collaborator

@wolfgang-ch wolfgang-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not yet done with this review but for today it is enough

bundles/net.tourbook/src/de/byteholder/geoclipse/mapprovider/DialogMPCustom.java Show resolved Hide resolved
bundles/net.tourbook/src/de/byteholder/geoclipse/mapprovider/DialogMPProfile.java Show resolved Hide resolved
bundles/net.tourbook/src/net/tourbook/map2/view/DialogMap2ExportViewImage.java Show resolved Hide resolved
bundles/net.tourbook/src/net/tourbook/map2/view/Map2View.java Show resolved Hide resolved
bundles/net.tourbook/src/net/tourbook/map2/view/Map2View.java Show resolved Hide resolved
bundles/net.tourbook/src/net/tourbook/map2/Messages.java Show resolved Hide resolved
bundles/net.tourbook/src/net/tourbook/map2/view/DialogMap2ExportViewImage.java Show resolved Hide resolved
@FJBDev
Copy link
Collaborator Author

FJBDev commented Jan 21, 2021

I'm not yet done with this review but for today it is enough

I have fixed all the issued from your comments of today but I will wait for your finalized review to create a new PR

wolfgang-ch
wolfgang-ch reviewed Jan 22, 2021
View reviewed changes
Copy link
Collaborator

@wolfgang-ch wolfgang-ch left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now the final code review for this PR

bundles/net.tourbook/src/net/tourbook/map2/view/DialogMap2ExportViewImage.java Show resolved Hide resolved
bundles/net.tourbook/src/net/tourbook/map2/action/ActionExportMapViewClipboard.java Show resolved Hide resolved
bundles/net.tourbook/src/net/tourbook/map2/action/ActionExportMapViewClipboard.java Show resolved Hide resolved
bundles/net.tourbook/src/de/byteholder/geoclipse/mapprovider/DialogMPCustom.java Show resolved Hide resolved
@FJBDev FJBDev mentioned this pull request Jan 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfgang-ch wolfgang-ch wolfgang-ch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FJBDev @wolfgang-ch