Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wolfi Package Request]: add openjdk jre headless package #142

Closed
2 of 3 tasks
tuananh opened this issue Nov 30, 2022 · 6 comments
Closed
2 of 3 tasks

[Wolfi Package Request]: add openjdk jre headless package #142

tuananh opened this issue Nov 30, 2022 · 6 comments
Labels
help wanted Extra attention is needed q123 wolfi-package-request used to track requests for new wolfi packages

Comments

@tuananh
Copy link
Contributor

tuananh commented Nov 30, 2022

What software would you like us to add to wolfi-os. Ideally include a URL to the project and its source.

need openjdk-11-jre-headless and openjdk-17-jre-headless subpackages.

which versions of the software should we include?

No response

Add some justification for why this specific package and versions are important.

There's a request for it here chainguard-images/images#91

Please check all that apply

  • This package has an un-restrictive license
  • I am interested in adding this package to Wolfi OS myself.
  • I am willing to help maintain this package.
@tuananh tuananh added needs-triage applied to all new customer/user issues. Removed after triage occurs. wolfi-package-request used to track requests for new wolfi packages labels Nov 30, 2022
@rawlingsj
Copy link
Member

I wonder if rather than adding two more packages for headless, if we should instead make our current JREs headless? I.e. review and strip out anything that is not strictly needed.

@patflynn
Copy link
Contributor

@rawlingsj I think that might defy expectations for folks. unless you clearly labeled it as jre-server or something like that.

@tuananh
Copy link
Contributor Author

tuananh commented Nov 30, 2022

I wonder if rather than adding two more packages for headless, if we should instead make our current JREs headless? I.e. review and strip out anything that is not strictly needed.

Could be since the goal of wolfi is container specific workload.

@rawlingsj
Copy link
Member

OK in that case let's create an extra headless package for each Java version.

@tuananh is that something you'd like to have a go at adding? I can see there's some steps in alpine's APKBUILD that look to create a jre headless subpackage https://git.alpinelinux.org/aports/tree/community/openjdk17/APKBUILD#n281 - that might be a good place to start and replicate in our melange config subpackage?

If not I can take a look later this week.

@tuananh
Copy link
Contributor Author

tuananh commented Nov 30, 2022

I'll take it.

@patflynn patflynn added help wanted Extra attention is needed q422 and removed needs-triage applied to all new customer/user issues. Removed after triage occurs. labels Dec 6, 2022
@patflynn patflynn added q123 and removed q422 labels Dec 22, 2022
@dlorenc
Copy link
Contributor

dlorenc commented Dec 28, 2022

This is fixed now!

@dlorenc dlorenc closed this as completed Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed q123 wolfi-package-request used to track requests for new wolfi packages
Projects
None yet
Development

No branches or pull requests

5 participants