Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

Commit

Permalink
Drop custom build step for excluding ssl_pyopenssl module from Python…
Browse files Browse the repository at this point in the history
… 3 builds. Ref cherrypy#1399. Fixes cherrypy#1149.
  • Loading branch information
jaraco committed Dec 26, 2016
1 parent c81ce2d commit a7e077d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 21 deletions.
9 changes: 9 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
v8.5.0
-----

* The pyOpenSSL support is now included on Python 3 builds,
removing the last disparity between Python 2 and Python 3
in the CherryPy package. This change is one small step
in consideration of #1399. This change also fixes RPM
builds, as reported in #1149.

v8.4.0
-----

Expand Down
21 changes: 0 additions & 21 deletions setup.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import sys
import re
import io
from distutils.command.install import INSTALL_SCHEMES
from distutils.command.build_py import build_py

import setuptools

Expand All @@ -11,20 +9,6 @@
pytest_runner = ['pytest_runner'] if needs_pytest else []


class cherrypy_build_py(build_py):
"""Custom version of build_py that excludes Python-specific modules"""

def build_module(self, module, module_file, package):
python3 = sys.version_info >= (3,)
if python3:
exclude_pattern = re.compile('ssl_pyopenssl')
else:
exclude_pattern = re.compile('xxx')
if exclude_pattern.match(module):
return # skip it
return build_py.build_module(self, module, module_file, package)


###############################################################################
# arguments for the setup command
###############################################################################
Expand Down Expand Up @@ -142,10 +126,6 @@ def build_module(self, module, module_file, package):
'mock' # accessed through cherrypy.test.helper.mock
)

cmd_class = {
'build_py': cherrypy_build_py,
}

if sys.version_info >= (3, 0):
required_python_version = '3.1'
else:
Expand Down Expand Up @@ -175,7 +155,6 @@ def build_module(self, module, module_file, package):
packages=packages,
data_files=data_files,
scripts=scripts,
cmdclass=cmd_class,
install_requires=install_requires,
extras_require=extras_require,
setup_requires=[
Expand Down

0 comments on commit a7e077d

Please sign in to comment.