Add type hints #59
Merged
Add type hints #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please rebase master? |
The example in `options_map_func.py` shows that the intention of the custom handler `options_map`func` is to make arbitrary objects printable. Thus, the type annotations had to be extended to support this usecase.
Instead of having an optional function the function is mandatory now but has a default value. This allows to drop a case distinction and, much more importantly, drop many of the alternatives of the type hints.
The examples still tried to unpack the returned list. This was not a good demonstration of the new, streamlined, return style type.
|
@wong2 could you pls merge it? |
|
Hi @wong2 , it seems as if this PR got stalled quite a bit. Is there anything I could do in order to get it merged? |
|
Thanks @MaxG87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As announced in #52 this pull request adds type hints. It changes how certain functions have to be used, so it requires an increment of the major version, according to SemVer.
By adding type hints I made the existing complexity of
pickexplicit. I managed to simplify things by two changes:options_map_functo get rid of a default type.I adapted the tests and examples. I make use of my fork of
pickin another project, mtv-cli. There it helped me to get rid of some type warnings, but it is not yet extensive use or battle tested or something.