Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to scroll to place order button with long payment method description #637

Closed
gedex opened this issue Aug 1, 2017 · 13 comments
Closed
Assignees
Labels
type: bug The issue is a confirmed bug.
Milestone

Comments

@gedex
Copy link
Member

gedex commented Aug 1, 2017

I just set up a test store on WPCOM and use Storefront (2.2.4). Currently, there's a bug in Stripe where payment method description gets concatenated. However, with this long description, I'm not able to scroll to click the place order button. Here's the recording of it:

storefront-issue

/cc @jameskoster as we had talk about this before

@gedex gedex added the type: bug The issue is a confirmed bug. label Aug 1, 2017
@tiagonoronha
Copy link
Contributor

@gedex what do I need to do to replicate this issue?

I tried different methods and no mater how long the description is, scrolling still works.

@gedex
Copy link
Member Author

gedex commented Aug 3, 2017

@tiagonoronha

This is reproducible on my test site:

  • Use incognito to open https://akeda-test-at-01.blog/
  • Add one product on that shop page to the cart
  • Go to the checkout page
  • Scroll to the bottom of the page
  • Choose Credit Cart (Stripe)
  • Scroll up a bit

The steps at checkout page seem intermittent, so here's a way to reproduce it consistently:

storefront-scroll-issue

I haven't tested this locally with master branch.

@mikeyarce
Copy link
Contributor

I wasn't able to reproduce this on my own site - I wonder if the height of the screen has to be a certain size for this to happen?

@gedex
Copy link
Member Author

gedex commented Aug 11, 2017

I'm not sure. My window size: 1920px x 1173px.

@mikeyarce
Copy link
Contributor

I can reproduce this on your test site, when my browser is set to 80% size (probably because I'm on a 13'' Macbook pro and you have a 15'' macbook pro?

I can't reproduce this on my own site.

@jameskoster what are your thoughts on removing this feature entirely? My reasoning is that it feels a bit unexpected when it's there - I have always preferred things not moving around.

@gedex
Copy link
Member Author

gedex commented Aug 12, 2017

and you have a 15'' macbook pro?

Correct. I'm using 15" MBP.

@jameskoster
Copy link
Member

@jameskoster what are your thoughts on removing this feature entirely? My reasoning is that it feels a bit unexpected when it's there - I have always preferred things not moving around.

I don't know... I still believe having the purchase button permanently visible is a useful feature. Maybe we could simplify it so that only the purchase button sticks, rather than the entire order summary? That would reduce the scope for quirks like this dramatically.

Of course we could just remove it entirely, but we'd need a feature plugin to add the functionality back in if we did so.

What do you think @tiagonoronha ?

@tiagonoronha
Copy link
Contributor

@jameskoster I think of it as fluff, I wouldn't be against removing it a putting into a feature plugin.

@jameskoster
Copy link
Member

Let's remove it.

@RiaanKnoetze
Copy link

@jameskoster @tiagonoronha - any news on a release date for 2.3.0?

@tiagonoronha
Copy link
Contributor

@RiaanKnoetze 2.2.6 will go out this week.

@nathanhere
Copy link

nathanhere commented Jan 2, 2018

Lost a customer today because of this. Crude CSS fix that worked for me:
.woocommerce-checkout-review-order.payment-fixed { height: 90% !important; overflow-y: scroll !important }

@jameskoster
Copy link
Member

Sorry to hear that @nathanhere. A better fix; wp_dequeue_script( 'storefront-sticky-payment' );.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug The issue is a confirmed bug.
Projects
None yet
Development

No branches or pull requests

6 participants