Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Component Styles: Add library color palette, sizing, fonts as sass variables #119

Closed
ryelle opened this issue Jun 15, 2018 · 7 comments
Closed
Labels
type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@ryelle
Copy link
Member

ryelle commented Jun 15, 2018

This supersedes #64. We'll want to make sure all pages and components are using consistent colors, font sizes, and spacing rhythm, which we can do by creating sass variables and mixins. As the hifi designs stabilize, we can grab this info and set up the right variables. Then we can update the existing components to the hifi designs, using the new variables.

@LevinMedia @jameskoster @josemarques When designs have settled (or if they are already), can you either link to an invision project with all your library components, or post an export of this info?

@ryelle ryelle added the type: task The issue is an internally driven task (e.g. from another A8c team). label Jun 15, 2018
@jameskoster
Copy link
Member

@LevinMedia I'm thinking we should make our symbols library the source for this. Agreed?

@ryelle
Copy link
Member Author

ryelle commented Aug 9, 2018

@jameskoster @LevinMedia I think most of what's needed here is in p6riRB-3ja-p2 👍 Are there hover/active/focus styles for plain links (for example the ActivityPanel breadcrumbs, or the links in report tables) anywhere?

@jameskoster
Copy link
Member

Link hover/active/focus styles should simply match GB core, but purpleised.

Re table links, I think reports should behave just like all other links. We have some tables on the dashboard as well though; "Top selling products" etc. These are slightly different as the entire row should be the link. The hover style for the row should match the other tables as per p6riRB-3lZ-p2

@ryelle
Copy link
Member Author

ryelle commented Aug 10, 2018

This is for generic styles, so I'll move your table feedback to #286

Can you give me actual colors for hover/active/focus? I think it's $woocommerce-500/#95588a for a neutral link, but I'm not sure how much lighter you want it for hover; should the focus style stay a blue halo, or do you want a purple halo?

@jameskoster
Copy link
Member

jameskoster commented Aug 13, 2018

I think $woocommerce-400 should work for hover; #af72a4.

For the focus styles, a purple halo using $woocommerce-200 (#e2a5d7 ) with text color $woocommerce-800 (#490c3e) would be good.

@belcherj
Copy link
Contributor

@ryelle Is this complete? Can we close?

@timmyc
Copy link
Contributor

timmyc commented Nov 27, 2018

Closing this out, we can re-open if need be.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Development

No branches or pull requests

4 participants