Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Dashboard: The performance card shows visitor stats for custom range of length longer than 1 day #11546

Closed
itsmeichigo opened this issue May 20, 2024 · 1 comment
Closed

Dynamic Dashboard: The performance card shows visitor stats for custom range of length longer than 1 day #11546

itsmeichigo opened this issue May 20, 2024 · 1 comment
Assignees
@hichamboushaba
Labels
feature: My Store screen Related to home screen project type: bug A confirmed bug.

Comments

@itsmeichigo
Copy link

Describe the bug
When switching between different time ranges on the performance card, then switch to custom range, the visitor stats is displayed even though the range length is longer than 1 day.

To Reproduce
Steps to reproduce the behavior:

  1. Log in to the app and enable Performance card on the My Store screen.
  2. Switch to a non-custom range time range.
  3. Then switch to a custom range.
  4. Notice that a visitor stat is display on top of the redacted view.

Screenshots

Expected behavior
Visitor stats should be hidden for custom range of length longer than 1 day.
@itsmeichigo itsmeichigo added the type: bug A confirmed bug. label May 20, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented May 20, 2024 •
edited
Loading

Thanks for reporting! 👍

@hichamboushaba hichamboushaba added the feature: My Store screen Related to home screen project label May 20, 2024
@hichamboushaba hichamboushaba self-assigned this May 21, 2024
hichamboushaba added a commit that referenced this issue May 21, 2024
@hichamboushaba
Revert the logic of observing the date range as key to update stats
cf91c75 
This causes an issue where we refresh the View when not needed, and causes some inconsistencies like #11546
@hichamboushaba hichamboushaba mentioned this issue May 21, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hichamboushaba hichamboushaba

Labels
feature: My Store screen Related to home screen project type: bug A confirmed bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hichamboushaba @itsmeichigo @dangermattic