Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image minimum size restrictions from 600x600 to 400x400 #11368

Merged
merged 2 commits into from Apr 24, 2024

Conversation

JorgeMucientes
Copy link
Contributor

Closes: #11367

Description

Reduce the minimum ad image size restriction from 600x600 to 400x400px

The API will now handle upscaling the image when needed if the uploaded image is smaller than 600x600px but larger than 400x400px.

The goal is to unblock users when creating Blaze ads, that have smaller product images. Full context here: p1713450773231259/1712831081.385859-slack-C069RG07W6S

Testing instructions

  1. Start Blaze campaign creation flow
  2. Click on Edit ad button
  3. Attempt adding an image under 400x400px and check dialog is displayed showing invalid image message
  4. Attempt to add an image over 400x400px and check is added correctly

Images/gif

imageAtLeast400x400.mp4

@JorgeMucientes JorgeMucientes added feature: blaze Related to the Blaze project unit-tests-exemption labels Apr 24, 2024
@JorgeMucientes JorgeMucientes added this to the 18.4 milestone Apr 24, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Apr 24, 2024

1 Warning
⚠️ This PR is assigned to the milestone 18.4. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@JorgeMucientes JorgeMucientes marked this pull request as ready for review April 24, 2024 07:46
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commitd84e06f
Direct Downloadwoocommerce-prototype-build-pr11368-d84e06f.apk

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 41.14%. Comparing base (98cc713) to head (d84e06f).
Report is 8 commits behind head on trunk.

Files Patch % Lines
...reation/ad/BlazeCampaignCreationEditAdViewModel.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #11368   +/-   ##
=========================================
  Coverage     41.14%   41.14%           
  Complexity     5218     5218           
=========================================
  Files          1058     1058           
  Lines         62316    62316           
  Branches       8506     8506           
=========================================
  Hits          25640    25640           
  Misses        34372    34372           
  Partials       2304     2304           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0nko 0nko self-assigned this Apr 24, 2024
Copy link
Contributor

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@0nko 0nko merged commit e37a3d1 into trunk Apr 24, 2024
14 checks passed
@0nko 0nko deleted the issue/11367-blaze-min-image-size-requirement-update branch April 24, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: blaze Related to the Blaze project unit-tests-exemption
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Blaze image min size restrictions from 600x600 to 400x400px
5 participants