Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update image minimum size restrictions from 600x600 to 400x400 #11368

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Update image minimum size restrictions from 600x600 to 400x400 #11368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb06a97
Update image minimum size restrictions to 400x400
JorgeMucientes Apr 24, 2024
d84e06f
Update release notes
JorgeMucientes Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*** PLEASE FOLLOW THIS FORMAT: [<priority indicator, more stars = higher priority>] <description> [<PR URL>]
18.4
-----
- [internal] Blaze: Change campaign image minimum expected dimensions. [https://github.com/woocommerce/woocommerce-android/pull/11368]


18.3
Expand Down
2 changes: 1 addition & 1 deletion WooCommerce/src/main/kotlin/com/woocommerce/android/ui/blaze/BlazeRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class BlazeRepository @Inject constructor(
const val CAMPAIGN_MAXIMUM_DAILY_SPEND = 50f // USD
const val CAMPAIGN_MAX_DURATION = 28 // Days
const val DEFAULT_CAMPAIGN_BUDGET_MODE = "total" // "total" or "daily" for campaigns that run without end date
const val BLAZE_IMAGE_MINIMUM_SIZE_IN_PIXELS = 600 // Must be at least 600 x 600 pixels
const val BLAZE_IMAGE_MINIMUM_SIZE_IN_PIXELS = 400 // Must be at least 400 x 400 pixels
}

fun observeLanguages() = blazeCampaignsStore.observeBlazeTargetingLanguages()
Expand Down
8 changes: 4 additions & 4 deletions ...tlin/com/woocommerce/android/ui/blaze/creation/ad/BlazeCampaignCreationEditAdViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ class BlazeCampaignCreationEditAdViewModel @Inject constructor(
it.copy(adImage = BlazeRepository.BlazeCampaignImage.LocalImage(uri))
}
} else {
showInvalidIMageDialog()
showInvalidImageSizeDialog()
}
}
}
Expand All @@ -138,16 +138,16 @@ class BlazeCampaignCreationEditAdViewModel @Inject constructor(
)
}
} else {
showInvalidIMageDialog()
showInvalidImageSizeDialog()
}
}
}

private fun showInvalidIMageDialog() {
private fun showInvalidImageSizeDialog() {
triggerEvent(
Event.ShowDialog(
titleId = R.string.blaze_campaign_edit_ad_invalid_image_title,
messageId = R.string.blaze_campaign_edit_ad_invalid_image_size_description,
messageId = R.string.blaze_campaign_edit_ad_invalid_image_description,
positiveButtonId = R.string.dialog_ok,
positiveBtnAction = { dialog, _ ->
dialog.dismiss()
Expand Down
2 changes: 1 addition & 1 deletion WooCommerce/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3834,7 +3834,7 @@
<string name="blaze_campaign_edit_ad_characters_remaining">%d characters remaining</string>
<string name="blaze_campaign_edit_ad_suggested_by_ai">Suggested by AI</string>
<string name="blaze_campaign_edit_ad_invalid_image_title">Invalid image</string>
<string name="blaze_campaign_edit_ad_invalid_image_size_description">Please select and image with a minimum dimension of 600x600 pixels</string>
<string name="blaze_campaign_edit_ad_invalid_image_description">Please select an image with a minimum size of 400x400 pixels</string>

<!--
Blaze campaign payment
Expand Down