-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Payment Method Improvements] Suggested changes from previous PR #11593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backwardstruck
added
type: enhancement
A request for an enhancement.
feature: mobile payments
Related to mobile payments / card present payments / Woo Payments.
status: feature-flagged
Behind a feature flag. Milestone is not strongly held.
labels
May 27, 2024
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/payments/changeduecalculator/ChangeDueCalculatorScreen.kt
kidinov
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature: mobile payments
Related to mobile payments / card present payments / Woo Payments.
status: feature-flagged
Behind a feature flag. Milestone is not strongly held.
type: enhancement
A request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11592 and #11619
Description
Suggested changes from previous PR
This PR addresses several improvements and fixes:
WCOutlinedTypedTextField
similar toOrderCreateEditProductDiscountScreen
.Ticket here.
Testing instructions
Enable OTHER_PAYMENT_METHODS
Navigate to the payment method selection screen by selecting Cash for an order that needs to be paid.
Verify Text Field and Dark Mode:
WCOutlinedTypedTextField
functionality.Scroll Functionality:
Background Consistency:
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.