Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment Method Improvements] Suggested changes from previous PR #11593

Merged
merged 28 commits into from
May 30, 2024

Conversation

backwardstruck
Copy link
Contributor

@backwardstruck backwardstruck commented May 27, 2024

Closes: #11592 and #11619

Description

Suggested changes from previous PR

This PR addresses several improvements and fixes:

  1. WCOutlinedTypedTextField Usage: Updated to use WCOutlinedTypedTextField similar to OrderCreateEditProductDiscountScreen.
  2. Text Color Fix in Dark Mode: Addressed the issue where text color in dark mode was incorrect; ensured it appears white.
  3. Scrollable Screen: Ensured that the screen is scrollable so users can reach the bottom even when the keyboard is open.
  4. Consistent Background: Made the background consistent with the rest of the application screens.
    Ticket here.

Testing instructions

  1. Enable OTHER_PAYMENT_METHODS

  2. Navigate to the payment method selection screen by selecting Cash for an order that needs to be paid.

  3. Verify Text Field and Dark Mode:

    • Check the WCOutlinedTypedTextField functionality.
    • Ensure that the text color is white when in dark mode.
  4. Scroll Functionality:

    • Open the keyboard on the payment method screen and ensure that the screen is scrollable.
  5. Background Consistency:

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@backwardstruck backwardstruck added this to the 18.9 milestone May 27, 2024
@backwardstruck backwardstruck added type: enhancement A request for an enhancement. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. status: feature-flagged Behind a feature flag. Milestone is not strongly held. labels May 27, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 27, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commite8b4d71
Direct Downloadwoocommerce-prototype-build-pr11593-e8b4d71.apk

@backwardstruck backwardstruck marked this pull request as ready for review May 27, 2024 19:05
Base automatically changed from 11525-change-due-calculator-ui-part-3 to trunk May 28, 2024 13:57
# Conflicts:
#	WooCommerce/src/main/kotlin/com/woocommerce/android/ui/payments/changeduecalculator/ChangeDueCalculatorScreen.kt
@backwardstruck
Copy link
Contributor Author

backwardstruck commented May 29, 2024

FYI @kidinov I created a separate ticket for the background theming (but that should now be fixed in this PR anyway):
#11619

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 18.9. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

Copy link
Contributor

@kidinov kidinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kidinov kidinov merged commit 5208114 into trunk May 30, 2024
14 checks passed
@kidinov kidinov deleted the 11592-suggested-changes-from-previous-pr branch May 30, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: mobile payments Related to mobile payments / card present payments / Woo Payments. status: feature-flagged Behind a feature flag. Milestone is not strongly held. type: enhancement A request for an enhancement.
Projects
None yet
4 participants