[Payment Method Improvements] Create the "Mark Order as Complete" Button #11570
Conversation
backwardstruck
added
type: enhancement
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
…e-due-calculator-ui-part-4 # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/payments/changeduecalculator/ChangeDueCalculatorFragment.kt # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/payments/changeduecalculator/ChangeDueCalculatorScreen.kt
…e-due-calculator-ui-part-4
| it.requestFocus() | ||
| context.getSystemService( | ||
| InputMethodManager::class.java | ||
| ).showSoftInput(it, InputMethodManager.SHOW_IMPLICIT) |
There was a problem hiding this comment.
I would like this to work the same as CustomAmountsFragment and pop the num pad but for some reason I'm seeing the full keyboard.
There was a problem hiding this comment.
Have you considered using WCOutlinedTypedTextField the same as they do in OrderCreateEditProductDiscountScreen? There are quite a few advantages of not using "XML" views in compose, including that now preview doesn't work
There was a problem hiding this comment.
Great suggestion. Indeed it broke the preview and I would prefer to use proper Compose views. I will change this today in this draft PR:
#11587
|
Feel free to fix that in the following PRs (or may it's already fixed, not sure):
05-27--15-16.mp4 |
.../kotlin/com/woocommerce/android/ui/payments/changeduecalculator/ChangeDueCalculatorScreen.kt
Show resolved
Hide resolved
| ).showSoftInput(it, InputMethodManager.SHOW_IMPLICIT) | ||
| } | ||
| } | ||
|
|
||
| AndroidView( |
There was a problem hiding this comment.
In case you still would want to steak with AndroidView reuse here, I'd suggest to export that into a separate composable function for code simplification
Thanks a lot. I added those items to my ticket here: |
backwardstruck
merged commit e4f14b7
into
11525-change-due-calculator-ui-part-3
Closes: #11525
Depends on this PR being merged first:
#11569
Description
Create the "Mark Order as Complete" Button in the Change Due Calculator screen and make sure to get keyboard focus for Cash Received field.
Testing instructions
Expected: You should see the Change Due screen with the num pad open and Cash Received in focus
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.