-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark Mode: Base Login Screens #2266
Conversation
c826be2 Merge pull request #35 from wordpress-mobile/feature/login-style-changes-v2 1f6c6e4 Gutenberg/integrate release 1.25.0 with dark mode (#11580) 1d668f5 Merge pull request #11537 from wordpress-mobile/fix/10930-email-error-dissapears-on-rotation fd66652 store the res id instead of the boolean so it supports multiple errors. 858decb utilized runnable that's posted when the UI has been drawn. ab37113 removed clearing in text watcher. 3691e84 Fixed config change issues. fd0c8c9 Merge pull request #34 from wordpress-mobile/merge/WordPress-Android/11492 c134376 Merge commit 'e80a69322fe65ad994bee1854a2343c2089af323' into issue/fix-login-subtree 5269196 Ignore onDiscoverySucceeded events if LoginBaseDiscoveryFragment is detached 775f096 Revert "Feature/material theme and Dark Theme support (#11469)" (#11486) 65d5c8f Feature/material theme and Dark Theme support (#11469) e80a693 Merge pull request #33 from wordpress-mobile/merge/WordPress-Android/11051 7e46000 Fix validation in input of Email 4f4657f Add requested changes d80e8e6 Remove whitespaces b187035 Issue/10930 email address error is preserved on rotation git-subtree-dir: libs/login git-subtree-split: c826be2
- Add new basic login theme support. Nothing configured.
Dark Mode: Cleanup Stragglers and minor views
Error TypeError
Dangerfile
Generated by 🚫 dangerJS |
You can test the changes on this Pull Request by downloading the APK here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Closes #1586 by pulling in the new theming added to the WordPress-Login-Lib and implementing the new styles and image assets. This PR does not include the login prologue or custom dialogs not included in the wordpress library. Those are coming next :)
NOTE: the app will crash if you try to login with a store that doesn't have Jetpack installed. That'll be fixed in the next PR when I convert that dialog. 👍
Site address screen
Email screen
Email password screen
The field icons have been removed with the latest changes to the wordpress library, but I'm not sure why. I'll have to do more digging to find out why that is so we can work on adding them back in in the next version. Here's what it used to look like for reference:
Magic Link Request
There wasn't a way to style the avatar in this view so I had to duplicate the image asset.
Magic link sent
This screen is also embedded in the WordPress login library so in order to scale the image and move the link, I'll need to implement a new layout override - which can be done in the next version :)
What is my site dialog
This dialog is embedded in the library so the only part I could change at this point is the picture. I'm pretty sure I can override the layout entirely so this change is still possible in the next version
Site Login
Just like the email password screen, the field icons have been removed with the latest changes to the wordpress library. I'll have to do more digging to find out why that is so we can work on adding them back in in the next version. Here's how the view used to look: