-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Dark Mode Login Screens #2286
Conversation
c826be2 Merge pull request #35 from wordpress-mobile/feature/login-style-changes-v2 1f6c6e4 Gutenberg/integrate release 1.25.0 with dark mode (#11580) 1d668f5 Merge pull request #11537 from wordpress-mobile/fix/10930-email-error-dissapears-on-rotation fd66652 store the res id instead of the boolean so it supports multiple errors. 858decb utilized runnable that's posted when the UI has been drawn. ab37113 removed clearing in text watcher. 3691e84 Fixed config change issues. fd0c8c9 Merge pull request #34 from wordpress-mobile/merge/WordPress-Android/11492 c134376 Merge commit 'e80a69322fe65ad994bee1854a2343c2089af323' into issue/fix-login-subtree 5269196 Ignore onDiscoverySucceeded events if LoginBaseDiscoveryFragment is detached 775f096 Revert "Feature/material theme and Dark Theme support (#11469)" (#11486) 65d5c8f Feature/material theme and Dark Theme support (#11469) e80a693 Merge pull request #33 from wordpress-mobile/merge/WordPress-Android/11051 7e46000 Fix validation in input of Email 4f4657f Add requested changes d80e8e6 Remove whitespaces b187035 Issue/10930 email address error is preserved on rotation git-subtree-dir: libs/login git-subtree-split: c826be2
- Add new basic login theme support. Nothing configured.
Darkmode/login theme 1
Dark Mode: Jetpack views
…ce/woocommerce-android into feature/darkmode-login
Dark Mode: Login welcome screens
Error TypeError
Dangerfile
Generated by 🚫 dangerJS |
You can test the changes on this Pull Request by downloading the APK here. |
Dark Mode: Login theme status bar color fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice work @AmandaRiu
This PR merges all the previously reviewed and approved login-related PRs into the
release/4.1
branch so it can get included in the current release. Here are a list of the included PRs:cc: @oguzkocer to be notified when PR approved.