Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Dark Mode Login Screens #2286

Merged
merged 25 commits into from
Apr 21, 2020
Merged

Conversation

AmandaRiu
Copy link
Contributor

@AmandaRiu AmandaRiu commented Apr 20, 2020

This PR merges all the previously reviewed and approved login-related PRs into the release/4.1 branch so it can get included in the current release. Here are a list of the included PRs:

cc: @oguzkocer to be notified when PR approved.

AmandaRiu and others added 22 commits April 16, 2020 20:32
c826be2 Merge pull request #35 from wordpress-mobile/feature/login-style-changes-v2
1f6c6e4 Gutenberg/integrate release 1.25.0 with dark mode (#11580)
1d668f5 Merge pull request #11537 from wordpress-mobile/fix/10930-email-error-dissapears-on-rotation
fd66652 store the res id instead of the boolean so it supports multiple errors.
858decb utilized runnable that's posted when the UI has been drawn.
ab37113 removed clearing in text watcher.
3691e84 Fixed config change issues.
fd0c8c9 Merge pull request #34 from wordpress-mobile/merge/WordPress-Android/11492
c134376 Merge commit 'e80a69322fe65ad994bee1854a2343c2089af323' into issue/fix-login-subtree
5269196 Ignore onDiscoverySucceeded events if LoginBaseDiscoveryFragment is detached
775f096 Revert "Feature/material theme and Dark Theme support (#11469)" (#11486)
65d5c8f Feature/material theme and Dark Theme support (#11469)
e80a693 Merge pull request #33 from wordpress-mobile/merge/WordPress-Android/11051
7e46000 Fix validation in input of Email
4f4657f Add requested changes
d80e8e6 Remove whitespaces
b187035 Issue/10930 email address error is preserved on rotation

git-subtree-dir: libs/login
git-subtree-split: c826be2
- Add new basic login theme support. Nothing configured.
@AmandaRiu AmandaRiu added Login category: design Layout and style elements in the UI or user interface, including color and animations. labels Apr 20, 2020
@AmandaRiu AmandaRiu added this to the 4.1 milestone Apr 20, 2020
@peril-woocommerce
Copy link

peril-woocommerce bot commented Apr 20, 2020

Fails
🚫

Danger failed to run /app/danger-0.sblk42t2icp.ts.

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.
Messages
📖

This PR contains changes in the subtree libs/login/. It is your responsibility to ensure these changes are merged back into wordpress-mobile/WordPress-Login-Flow-Android. Follow these handy steps!
WARNING: Make sure your git version is 2.19.x or lower - there is currently a bug in later versions that will corrupt the subtree history!

  1. cd woocommerce-android
  2. git checkout feature/darkmode-login
  3. git subtree push --prefix=libs/login/ https://github.com/wordpress-mobile/WordPress-Login-Flow-Android.git merge/woocommerce-android/2286
  4. Browse to https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/pull/new/merge/woocommerce-android/2286 and open a new PR.

Error TypeError

Cannot read property 'diff' of null
TypeError: Cannot read property 'diff' of null
    at checkCommitDiffs (/app/danger-0.sblk42t2icp.ts:43:49)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Dangerfile

38|         if (git === undefined) {
39|             console.log("About to crash due to an error")
40|             console.log("File:", thisFile)
41|             console.log("Danger Object: ", danger)
42| 
---------------------------------------------------^
43|             if (danger !== undefined) {
44|                 console.log("Danger is no longer defined")
45|             }
46|             else {

Generated by 🚫 dangerJS

@peril-woocommerce
Copy link

peril-woocommerce bot commented Apr 20, 2020

You can test the changes on this Pull Request by downloading the APK here.

@AmandaRiu AmandaRiu changed the base branch from develop to release/4.1 April 20, 2020 22:08
@AmandaRiu AmandaRiu changed the title Feature/darkmode login Feature: Dark Mode Login Screens Apr 20, 2020
Dark Mode: Login theme status bar color fix
@AmandaRiu AmandaRiu marked this pull request as ready for review April 21, 2020 00:06
@anitaa1990 anitaa1990 self-assigned this Apr 21, 2020
Copy link
Contributor

@anitaa1990 anitaa1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice work @AmandaRiu :shipit:

@anitaa1990 anitaa1990 merged commit 2942bb9 into release/4.1 Apr 21, 2020
@anitaa1990 anitaa1990 deleted the feature/darkmode-login branch April 21, 2020 05:11
@designsimply designsimply added feature: login Related to any part of the log in or sign in flow, or authentication. and removed Login labels May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: design Layout and style elements in the UI or user interface, including color and animations. feature: login Related to any part of the log in or sign in flow, or authentication.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants