Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Login bugfix: Make site address password screen scrollable #2916

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

AmandaRiu
Copy link
Contributor

@AmandaRiu AmandaRiu commented Sep 24, 2020

Closes #2897 by nesting the layout in a ScrollView so buttons no longer overlap on smaller screens.

Before After
Screenshot_1600981495 Screenshot_1600981390

To Test

  1. First update your devices settings to set Display Size to Larger and Font size to Large - this will just make it easier to test this issue.
  2. Start logged out of the app.
  3. Select "Enter your store address."
  4. Enter your store address and select "Continue."
  5. On the "Enter email address" screen, try scrolling the view and verify all buttons are now accessible and no longer overlapped.

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@AmandaRiu AmandaRiu added type: bug A confirmed bug. Login labels Sep 24, 2020
@AmandaRiu AmandaRiu added this to the 5.1 ❄️ milestone Sep 24, 2020
@AmandaRiu AmandaRiu requested a review from a team September 24, 2020 21:10
@peril-woocommerce
Copy link

peril-woocommerce bot commented Sep 24, 2020

Fails
🚫

Danger failed to run /app/danger-0.j5vh1h9xfn.ts.

Messages
📖

This PR contains changes in the subtree libs/login/. It is your responsibility to ensure these changes are merged back into wordpress-mobile/WordPress-Login-Flow-Android. Follow these handy steps!
WARNING: Make sure your git version is 2.19.x or lower - there is currently a bug in later versions that will corrupt the subtree history!

  1. cd woocommerce-android
  2. git checkout issue/2897-overlap-ul
  3. git subtree push --prefix=libs/login/ https://github.com/wordpress-mobile/WordPress-Login-Flow-Android.git merge/woocommerce-android/2916
  4. Browse to https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/pull/new/merge/woocommerce-android/2916 and open a new PR.

Error TypeError

Cannot read property 'diff' of null
TypeError: Cannot read property 'diff' of null
    at checkCommitDiffs (/app/danger-0.j5vh1h9xfn.ts:43:49)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Dangerfile

38|         if (git === undefined) {
39|             console.log("About to crash due to an error")
40|             console.log("File:", thisFile)
41|             console.log("Danger Object: ", danger)
42| 
---------------------------------------------------^
43|             if (danger !== undefined) {
44|                 console.log("Danger is no longer defined")
45|             }
46|             else {

Generated by 🚫 dangerJS

@peril-woocommerce
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@anitaa1990 anitaa1990 self-assigned this Sep 25, 2020
@anitaa1990 anitaa1990 added this to In progress in Unified Login Sep 25, 2020
Copy link
Contributor

@anitaa1990 anitaa1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anitaa1990 anitaa1990 merged commit 0535c5d into release/5.1 Sep 25, 2020
@anitaa1990 anitaa1990 deleted the issue/2897-overlap-ul branch September 25, 2020 06:39
AmandaRiu added a commit that referenced this pull request Oct 29, 2020
0f54aa6 Merge pull request #46 from wordpress-mobile/merge/wcandroid-ul-m1
69cdd91 Fix merge conflicts
a955de5 Remove confusion over tag usage by renaming and fix social login bug
ff2b2cb Update to conform to changes from the Login Library
ac21a9e Merge commit '7fb87d9b60e417020e48bc33b89f4a3ffeb88a95' into issue/merge-login-lib-changes
c616393 Call login listener method for unregistered email if in WPcom login flow
895a4f5 Merge pull request #2930 from woocommerce/release/5.1
fc65d5c Merge pull request #2918 from woocommerce/issue/2911-tracks
cb75217 Merge pull request #2916 from woocommerce/issue/2897-overlap-ul
427d2e3 Add new methods for updating the step when resuming site creds screen
37998c4 Add new methods for updating the step when resuming magic link and site creds views
c4964cf Add new methods for updating the step when resuming site address and email password views
e87a28c Nest layout in a ScrollView so buttons no longer overlap on smaller screens
e58d872 Make screen scrollable for smaller displays and lower resolutions
5cf377a Allow login to complete if WPcom login without the woo-specific site address check
af41bb2 Null the site address view when the view is destroyed
9aefabe Resolved conflicts in login library build.gradle, pulled develop
c67f6fb Fix login flow memory leaks
695044d Merge pull request #2843 from woocommerce/issue/2721-tracks-2
f0302a7 Hide TOS buttons if not in signup mode during login
130b83f Updated gradle dependecy
3d99e1a Only log track failures if message is not null
a734985 Update button labels and add click events
946041b Add logic to route to login with wpcom creds flow
45f625d Style site creds login by magic link verification screen
f684c59 Handle magic link login
b4c8b8c Create alternative login email screen that provides site creds option
8d4ac00 Delete empty layouts created during merge and comment out usage
c9ace9d Merge commit 'b2b772d616c7d7e40c2b0d1c7d7a25e52ecbf59e' into issue/2655-unified-login-1
673ce5d Fix FluxC build
a069675 Update gradle plugin to 4.0 and gradle to 6.1.1
2fb113e Revert changes to gradle
a57069b Gradle updates.

git-subtree-dir: libs/login
git-subtree-split: 0f54aa6
@AmandaRiu AmandaRiu moved this from In progress to Done in Unified Login Oct 29, 2020
@designsimply designsimply added feature: login Related to any part of the log in or sign in flow, or authentication. and removed Login labels May 6, 2021
AnirudhBhat pushed a commit that referenced this pull request Aug 11, 2021
Unified Login bugfix: Make site address password screen scrollable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: login Related to any part of the log in or sign in flow, or authentication. type: bug A confirmed bug.
Projects
No open projects
Unified Login
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants