Unified login: Track event login step fixes

[AmandaRiu]

This PR fixes an issue where previously if the user clicked on the "Help" icon on any of the login views (not the epilogue screen - that will be a different PR), the Step would continue to be set to help erroneously even after the user returned to the regular login screen. For example:

On the site address screen the unified event string would normally look like then when you click Continue:

{"source":"default","flow":"login_site_address","step":"start","click":"submit"}

But, if you click "help" while on this screen, then click back to return to the site address screen and then click Continue, the event looks like this:

{"source":"default","flow":"login_site_address","step":"help","click":"submit"}

To fix this I've added some additional login listeners for setting the appropriate step when that view resumes:

• emailPasswordFormScreenResumed()
• siteAddressFormScreenResumed()
• magicLinkRequestScreenResumed()
• fun magicLinkSentScreenResumed()
• usernamePasswordScreenResumed()

This cleans up the track event flow and makes it more accurate. Below are snippets from various scenarios. Notice how the Help button is clicked between screens to ensure the Step is accurately reset when resumed.

Login by Site Address

Tracked: unified_login_step, Properties: {"source":"default","flow":"prologue","step":"prologue"}
Tracked: unified_login_interaction, Properties: {"source":"default","flow":"prologue","step":"prologue","click":"login_with_site_address"}
Tracked: unified_login_step, Properties: {"source":"default","flow":"login_site_address","step":"start"}
Tracked: unified_login_interaction, Properties: {"source":"default","flow":"login_site_address","step":"start","click":"show_help"}
Tracked: unified_login_step, Properties: {"source":"default","flow":"login_site_address","step":"help"}
Tracked: unified_login_interaction, Properties: {"source":"default","flow":"login_site_address","step":"start","click":"submit"}
Tracked: unified_login_step, Properties: {"source":"default","flow":"login_site_address","step":"enter_email_address"}
Tracked: unified_login_interaction, Properties: {"source":"default","flow":"login_site_address","step":"enter_email_address","click":"show_help"}
Tracked: unified_login_step, Properties: {"source":"default","flow":"login_site_address","step":"help"}
Tracked: unified_login_interaction, Properties: {"source":"default","flow":"login_site_address","step":"enter_email_address","click":"submit"}
Tracked: unified_login_step, Properties: {"source":"default","flow":"login_magic_link","step":"start"}
Tracked: unified_login_interaction, Properties: {"source":"default","flow":"login_magic_link","step":"start","click":"login_with_password"}
Tracked: unified_login_step, Properties: {"source":"default","flow":"login_password","step":"start"}
Tracked: unified_login_interaction, Properties: {"source":"default","flow":"login_password","step":"start","click":"show_help"}
Tracked: unified_login_step, Properties: {"source":"default","flow":"login_password","step":"help"}
Tracked: unified_login_interaction, Properties: {"source":"default","flow":"login_password","step":"start","click":"submit"}
Tracked: unified_login_step, Properties: {"source":"default","flow":"login_password","step":"success"}

Site Credentials Screen

Tracked: unified_login_interaction, Properties: {"source":"default","flow":"login_site_address","step":"enter_email_address","click":"login_with_site_creds"}
Tracked: unified_login_step, Properties: {"source":"default","flow":"login_store_creds","step":"username_password"}
Tracked: unified_login_interaction, Properties: {"source":"default","flow":"login_store_creds","step":"username_password","click":"show_help"}
Tracked: unified_login_step, Properties: {"source":"default","flow":"login_store_creds","step":"help"}
Tracked: unified_login_interaction, Properties: {"source":"default","flow":"login_store_creds","step":"username_password","click":"submit"}

Login with WordPress.com

Tracked: unified_login_step, Properties: {"source":"default","flow":"wordpress_com","step":"enter_email_address"}
Tracked: unified_login_interaction, Properties: {"source":"default","flow":"wordpress_com","step":"enter_email_address","click":"show_help"}
Tracked: unified_login_step, Properties: {"source":"default","flow":"wordpress_com","step":"help"}
Tracked: unified_login_interaction, Properties: {"source":"default","flow":"wordpress_com","step":"enter_email_address","click":"submit"}
Tracked: unified_login_step, Properties: {"source":"default","flow":"login_magic_link","step":"start"}

To Test

Verify clicking the toolbar help button and then clicking back sends the correct track event on the following screens:

Site Address Login Flow

• Site address screen
• email screen
• site credentials screen
• magic link screens (requested and sent)

**WordPress.com

• email screen
• magic link screens

Update release notes:

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-woocommerce]

	Fails
🚫	Danger failed to run /app/danger-0.kfwmv0p60eq.ts.

Messages

📖

This PR contains changes in the subtree libs/login/. It is your responsibility to ensure these changes are merged back into wordpress-mobile/WordPress-Login-Flow-Android. Follow these handy steps! WARNING: Make sure your git version is 2.19.x or lower - there is currently a bug in later versions that will corrupt the subtree history! cd woocommerce-android git checkout issue/2911-tracks git subtree push --prefix=libs/login/ https://github.com/wordpress-mobile/WordPress-Login-Flow-Android.git merge/woocommerce-android/2918 Browse to https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/pull/new/merge/woocommerce-android/2918 and open a new PR.

Error TypeError

Cannot read property 'diff' of null
TypeError: Cannot read property 'diff' of null
    at checkCommitDiffs (/app/danger-0.kfwmv0p60eq.ts:43:49)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Dangerfile

38|         if (git === undefined) {
39|             console.log("About to crash due to an error")
40|             console.log("File:", thisFile)
41|             console.log("Danger Object: ", danger)
42| 
---------------------------------------------------^
43|             if (danger !== undefined) {
44|                 console.log("Danger is no longer defined")
45|             }
46|             else {

Generated by 🚫 dangerJS

[peril-woocommerce]

You can test the changes on this Pull Request by downloading the APK here.

[anitaa1990]

Verified all tracking events are sent correctly after clicking on Help and resuming the login flow! Nice work