This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix: Inner blocks control position for Cart Block #6973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inner block controls position.
tarunvijwani
added
status: needs review
type: bug
|
The release ZIP for this PR is accessible via: |
|
Size Change: -37 B (0%) Total Size: 874 kB
ℹ️ View Unchanged
|
tarhi-saad
suggested changes
Aug 26, 2022
There was a problem hiding this comment.
Hi @tarunvijwani! Thank you for fixing the block's control position bug! 🙌 You can find below my comment about a display bug!
assets/js/blocks/cart/edit.js
Outdated
| <BlockSettings | ||
| attributes={ attributes } | ||
| setAttributes={ setAttributes } | ||
| /> |
There was a problem hiding this comment.
Hi @tarunvijwani! The BlockSettings component is already added on line 80 of this file. With the current two BlockSettings we have double dark mode controls:
There was a problem hiding this comment.
Sorry, I missed them while resolving the merge conflict. I have removed the duplicate code. Thank you!
tarhi-saad
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
That's perfect, @tarunvijwani! It looks good to me! So, let's 🚀 it! 💪
tarunvijwani
deleted the
fix/6698-order-summary-inner-blocks-controls
branch
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
Cart Block: Order summary inner blocks controls were appearing on the left side of the screen
Changes in the PR
Removed
__experimentalExposeControlsToChildrenfromcart/index.jsandcart/edit.jsfile.__experimentalExposeControlsToChildrenwas added by the PR to display the view switcher when selecting the inner blocks of the Cart block. It was dependent on PR opened in Gutenberg repo, which was never merged.Currently, the view switcher is only visible when we select the parent Cart block, which is nearly impossible to select without using the list view option. It can be done now using a filter, I'll create a different ticket to track the issue
Fixes #6698
Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Changelog