Show extension metadata in order item details #4753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
allendav
reviewed
Aug 9, 2021
| @@ -21,7 +21,10 @@ public struct OrderItemAttribute: Decodable, Hashable, Equatable, GeneratedFakea | |||
| let container = try decoder.container(keyedBy: CodingKeys.self) | |||
| let metaID = try container.decode(Int64.self, forKey: .metaID) | |||
| let name = try container.decode(String.self, forKey: .name) | |||
| let value = try container.decode(String.self, forKey: .value) | |||
|
|
|||
| /// Some extensions sent the `value` field with non-string format. | |||
allendav
reviewed
Aug 9, 2021
| @@ -325,6 +337,12 @@ private extension OrderMapperTests { | |||
| return mapOrder(from: "order-with-line-item-attributes") | |||
| } | |||
|
|
|||
| /// Returns the OrderMapper output upon receiving `order-with-faulty-attributes` | |||
| /// | |||
| func mapLoadOrderWithFaultyAttributesResponse() -> Order? { | |||
There was a problem hiding this comment.
Please consider mentioning in a comment that the _measurement_data value having object format (and not a string) is what is "faulty" here. I had to fire up the debugger to understand what in the order was the problem.
allendav
approved these changes
Aug 9, 2021
|
Thanks for the review and suggestions @allendav! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4708
Why
It was reported(4182704-zd-woothemes) that merchants were able to see some order metadata in Android but not in iOS.
After some investigation, this happens because some extensions(like Measurement Price Calculator) adds some extra metadata that does not have the format we expect, hence making the whole metadata/attributes decoding to fail.
How
This PR solves the problem by making the
valuefield fromOrderItemAttributeto be decoded safely when an unexpected format is found.Screenshots
Testing Steps
Follow testings steps on #4708
Update release notes:
RELEASE-NOTES.txtif necessary.