Orders Search: User Interface

[jleandroperez]

Important:

• The UI of this approach differs from the mockups.
• Why: We didn't notice until we got hands on it, but having the SearchBar along with "Pull to Refresh" support leads to a quite poor UX: the user pulls to refresh, but ends up revealing the SearchBar, and must "pull further" to trigger the gesture.
• I'm making a call, and replicating Contacts.app (Standard iOS UX), with a caveat: We're basically implementing the exact same feature, but instead of hiding the SearchBar, we'll rely on a NavigationBar Button to enter the "Search Mode".

Details:

• Implemented OrderSearchViewController (barebones)
• Relocated all of the Order-Y cells to a folder named Cells
• Renamed: OrderListCell > OrderTableViewCell
• Renamed: AddANoteViewController > NewNoteViewController

Ref. #63

Notes:

• Cell Prototypes cannot be shared between multiple UIViewControllers within a Storyboard
• Because of the above, it doesn't really make sense to have all the things in a storyboard. In this PR i've detached the NewNoteViewController from Orders.storyboard (along with OrderTableViewCell!)

Testing: Skeleton

1. Fresh Install
2. Log into your Store
3. Open the Orders Tab

• Verify the Skeleton UI looks correctly

Testing: New Note

1. Log into your Store
2. Open the Orders Tab
3. Open any order's details
4. Press over the New Note row

• Verify the New Note UI looks good
• Add a new Note
• Verify the new Note shows up shortly onscreen

Testing: Search UI

1. Log into your Store
2. Open the Orders Tab
3. Press over the Top Left icon

• Verify the new UI shows up
• Verify that the Cancel button dismisses the new UI

---

[wpmobilebot]

	1 Warning
⚠️	PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 Danger

[mindgraffiti]

Crash on Test Search UI:
Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[WooCommerce.OrderSearchViewController tableView:numberOfRowsInSection:]: unrecognized selector sent to instance 0x12f91ba40'

[mindgraffiti]

Prototype Cells

thanks for taking care of this tech debt Jorge!

Note @bummytime the OrderSearchViewController is crashing because the tableview delegate methods aren't implemented in this PR --- they're in PR #559. I'm good with this getting merged if you are.

[bummytime]

Looks good Jorge. As @mindgraffiti mentioned in her review:

... the OrderSearchViewController is crashing because the tableview delegate methods aren't implemented in this PR --- they're in PR #559. I'm good with this getting merged if you are.

I saw the same issue. I am also fine merging this one and testing it altogether in #559

Nice job!