-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating Search Orders Action #559
Conversation
…grating-search-action
…grating-search-action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work as always @jleandroperez! All the interactions accounted for + an excellent search experience.
✅ code
✅ heavy UI testing
… issue/63-integrating-search-action * 'develop' of github.com:woocommerce/woocommerce-ios:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this very well...everything works like a champ! 🥊
✅ Codez
✅ Unit tests (green)
✅ Smoke testing
A++ Nice work @jleandroperez !
Note:
Includes PR #557
Includes PR #558
Please review once the former have been merged back into Develop (and, of course, merge develop back in, the code delta should be ~500 LOC, otherwise it's a review nightmare!).
Details:
Closes #63
Testing: Main Functionality
Testing: Offline Mode
Testing: Cache Interference
Testing: Fulfillment
Testing: Notes