Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating Search Orders Action #559

Merged
merged 9 commits into from
Jan 2, 2019

Conversation

jleandroperez
Copy link
Collaborator

@jleandroperez jleandroperez commented Dec 26, 2018

Note:

Includes PR #557
Includes PR #558

Please review once the former have been merged back into Develop (and, of course, merge develop back in, the code delta should be ~500 LOC, otherwise it's a review nightmare!).

Details:

  • Integrates the Search Orders UI with the Yosemite Action
  • Excludes Orders marked as exclusiveSearchResult from the Orders List
  • Cached Search results are available in offline mode. Ain't that awesome?

Closes #63

Testing: Main Functionality

  1. Open the Orders Tab and press the top right button (Magnifying Glass)
  • Verify the spinner shows up whenever we're in empty state
  • Verify the UI effectively retrieves orders that contain the Search Keyword
  • Verify Infinite Scroll effectively loads the next page
  • Verify the spinner shows up whenever the next page is being loaded

Testing: Offline Mode

  1. Open the Orders Tab and press the top right button (Magnifying Glass)
  2. Search for a keyword that return a few orders
  3. Toggle Airplane Mode
  4. Dismiss the Search UI + Reopen it
  • Verify that the keyword entered in (2) yields the same results

Testing: Cache Interference

  1. Open the Orders Tab and press the top right button (Magnifying Glass)
  2. Enter a keyword that yields an OLD order (that doesn't show up in the top 25 results)
  3. Toggle Airplane Mode
  4. Dismiss the Search UI
  5. Scroll all the way down
  • Verify that the orders displayed in Step 2 (that were never cached because of a regular Paging OP) do not show up, mixed up in the results
  • Verify that after disabling Airplane Mode, and scrolling down, such order shows up correctly

Testing: Fulfillment

  1. Open the Orders Tab and press the top right button (Magnifying Glass)
  2. Enter any keyword that yields an unfulfilled order
  3. Open the first Search Result
  4. Fulfill the order
  • Verify that the Order Details UI reflects the new Order State
  • Verify that the Search Results also reflect the new order State
  • Verify that the Orders List is also in sync (dismiss the search UI!)

Testing: Notes

  1. Open the Orders Tab and press the top right button (Magnifying Glass)
  2. Enter any keyword that yields any order, and open it
  • Verify that adding an Order Note works fine!
  • Verify that the Order (when opened via the Orders List) is in sync

@jleandroperez jleandroperez added the feature: order list Related to the order list. label Dec 26, 2018
@jleandroperez jleandroperez added this to the 0.15 milestone Dec 26, 2018
@jleandroperez jleandroperez self-assigned this Dec 26, 2018
@jleandroperez jleandroperez changed the title Integrating Search Orders Action [WIP] Integrating Search Orders Action Dec 26, 2018
@jleandroperez jleandroperez added this to Review/Testing in MVLP Kanban Board Dec 27, 2018
@mindgraffiti mindgraffiti mentioned this pull request Dec 27, 2018
8 tasks
@jleandroperez jleandroperez changed the title [WIP] Integrating Search Orders Action Integrating Search Orders Action Dec 27, 2018
Copy link
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work as always @jleandroperez! All the interactions accounted for + an excellent search experience.

✅ code
✅ heavy UI testing

:shipit:

… issue/63-integrating-search-action

* 'develop' of github.com:woocommerce/woocommerce-ios:
Copy link
Member

@bummytime bummytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this very well...everything works like a champ! 🥊

✅ Codez
✅ Unit tests (green)
✅ Smoke testing

A++ Nice work @jleandroperez ! :shipit:

@bummytime bummytime merged commit 9157dc4 into develop Jan 2, 2019
MVLP Kanban Board automation moved this from Review/Testing to Done/Merged Jan 2, 2019
@bummytime bummytime deleted the issue/63-integrating-search-action branch January 2, 2019 19:38
@astralbodies astralbodies modified the milestones: 0.15, App Store release Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: order list Related to the order list.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants