-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize Analytics Usage Tracking #5820
Merged
shiki
merged 11 commits into
issue/5501-prototype-analytics-tracking
from
issue/5501-analytics-tracking-finalize
Jan 6, 2022
Merged
Finalize Analytics Usage Tracking #5820
shiki
merged 11 commits into
issue/5501-prototype-analytics-tracking
from
issue/5501-analytics-tracking-finalize
Jan 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-tracking-finalize
…racking' into issue/5501-analytics-tracking-finalize
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can trigger an installable build for these changes by visiting CircleCI here. |
While not the best, I think this is good enough so that we can keep the UsageTracksEventEmitter dependency within the Stats-related code.
shiki
changed the title
Issue/5501 analytics tracking finalize
Finalize Analytics Usage Tracking
Jan 5, 2022
The StoreStatsV4PeriodViewController.trackChangedTabIfNeeded() is more than enough to detect if the merchant navigated back to My Store.
jaclync
approved these changes
Jan 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Code and testing with both feature flag states ✅
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhances #5503 so that it can be merged. I created a separate PR so that it's hopefully easier to review.
Changes
Removed Singleton
I removed the
StoreStatsUsageTracksEventEmitter
singleton and replaced it with injected properties instead: 5a834ce.In relation to this, I changed the My Store tab press detection to use
viewWillAppear
in b48094f to keep theStoreStatsUsageTracksEventEmitter
instance within theStoreStats*
classes. It felt incorrect to add theStoreStatsUsageTracksEventEmitter
insideMainTabBarController
. And subsequently, I realized that this causes duplication of "interaction tracking" sinceStoreStatsV4PeriodViewController. trackChangedTabIfNeeded
is also executed when the merchant navigates back to the My Store tab. So I just removed it in 0316ac3.Added Tracking to Old VCs
I noticed that there are
OldStoreStats*
classes now. I made sure to include the same interaction tracking to these classes.Others
Testing
used_analytics
Tracks event is logged.myStoreTabUpdates
feature flag and repeat steps 3 and 4.Author Checklist
RELEASE-NOTES.txt
if necessary.