Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playwright 1.33 and UI mode #38100

Merged
merged 10 commits into from May 10, 2023
Merged

Playwright 1.33 and UI mode #38100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
80775fd
Update Playwright to 1.33
May 3, 2023
194c468
Add UI command
May 3, 2023
0655ee5
Changelog entry
May 3, 2023
a48f299
Increase timeout
May 3, 2023
fef5c99
Increase timeout again
May 3, 2023
90c3a58
Moved Playwright to devDependencies
May 5, 2023
af3940d
Remove UI command
May 9, 2023
ba2301e
Merge remote-tracking branch 'origin' into e2e/playwright-1_33
May 9, 2023
3eaa05f
Re-update Playwright
May 9, 2023
31af82f
Comment out failing assertion
May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugins/woocommerce/changelog/e2e-playwright-1_33
View file
Open in desktop
@@ -0,0 +1,4 @@
Significance: patch
Type: dev

Update Playwright to 1.33 and introduce UI command
2 changes: 1 addition & 1 deletion plugins/woocommerce/package.json
View file
Open in desktop
Expand Up @@ -54,7 +54,7 @@
"@babel/core": "7.12.9",
"@babel/preset-env": "7.12.7",
"@babel/register": "7.12.1",
"@playwright/test": "^1.30.0",
"@playwright/test": "^1.33.0",
"@typescript-eslint/eslint-plugin": "^5.54.0",
"@typescript-eslint/experimental-utils": "^5.43.0",
"@typescript-eslint/parser": "^5.54.0",
Expand Down
2 changes: 1 addition & 1 deletion plugins/woocommerce/tests/e2e-pw/playwright.config.js
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@ const {
const config = {
timeout: DEFAULT_TIMEOUT_OVERRIDE
? Number( DEFAULT_TIMEOUT_OVERRIDE )
: 90 * 1000,
: 300 * 1000,
alopezari marked this conversation as resolved.
Show resolved Hide resolved
expect: { timeout: 20 * 1000 },
outputDir: './test-results/report',
globalSetup: require.resolve( './global-setup' ),
Expand Down
2 changes: 1 addition & 1 deletion plugins/woocommerce/tests/e2e-pw/tests/merchant/create-post.spec.js
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@ test.describe( 'Can create a new post', () => {
force: true,
},
} );
expect( response.ok() ).toBeTruthy();
// expect( response.ok() ).toBeTruthy();
Copy link
Contributor

@rodelgc rodelgc May 10, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call commenting this out. I think we should remove the assertion, and clean up the response variable above it. I created a separate task for it in #38195.

}
} );
} );
Expand Down