Add `Always show pre-publish checks` checkbox #44595

octaedro · 2024-02-13T22:07:54Z

Submission Review Guidelines:

I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have reviewed my code for security best practices.
Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

The sidebar/modal can be optional when the form doesn't contain any validation error.
This PR adds the Always show pre-publish checks checkbox.

Closes #43707.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Make sure the New product editor and the Prepublish sidebar (product-pre-publish-modal) are enabled under /wp-admin/admin.php?page=wc-settings&tab=advanced&section=features.
Go to Products > Add New.
Add a product name and press Publish.
The prepublish panel should be visible.
Verify that the Always show pre-publish checks checkbox is visible.

It should be checked by default.
Uncheck the checkbox and close the panel.
Press Publish again. Now, the panel shouldn't be visible anymore.
If you want to re-enable the panel, you should remove the option woocommerce_show_prepublish_checks_enabled from the database. You can do it at Tools > WCA Test Helper > Options.
Also verify the checkbox looks good on different screen sizes.

Changelog entry

Automatically create a changelog entry from the details below.

Significance

Patch
Minor
Major

Type

Fix - Fixes an existing bug
Add - Adds functionality
Update - Update existing functionality
Dev - Development related task
Tweak - A minor adjustment to the codebase
Performance - Address performance issues
Enhancement - Improvement to existing functionality

Message

Comment

github-actions · 2024-02-14T19:32:33Z

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

github-actions · 2024-02-14T20:07:26Z

Test Results Summary

Commit SHA: 925110f

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 38s
E2E Tests	332	0	0	13	0	345	7m 55s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

mdperez86

Nice job @octaedro LGTM!!!

# Conflicts: # packages/js/product-editor/src/components/prepublish-panel/prepublish-panel.tsx # Conflicts: # packages/js/product-editor/src/components/prepublish-panel/style.scss

# Conflicts: # packages/js/product-editor/src/components/header/header.tsx # Conflicts: # packages/js/product-editor/src/components/header/header.tsx

# Conflicts: # packages/js/product-editor/src/components/prepublish-panel/style.scss

…#44926)

…license file. (#44932)

By default `nodemon` only watches for JS file changes. This expands the config so that it watch the file extensions that are actually produced by builds.

* Update core package.json to remove nightly ci config * Add changefile(s) from automation for the following project(s): woocommerce --------- Co-authored-by: github-actions <github-actions@github.com>

* Update blocks build message * Add changefile(s) from automation for the following project(s): woocommerce * Update plugins/woocommerce/src/Blocks/Domain/Bootstrap.php Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> * Update plugins/woocommerce/src/Blocks/Domain/Bootstrap.php Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com>

* Update themes list on core. Update the themes data and remove hardcoded reference to free themes. * Update styles for the Free, Paid and active cards. * Add the color palletes to TT4 theme. * Update the references for default and core themes. * Add changefile(s) from automation for the following project(s): woocommerce * Update the link to TT4 theme * Update default value for price. --------- Co-authored-by: github-actions <github-actions@github.com>

* Add show-prepublish-checks-section # Conflicts: # packages/js/product-editor/src/components/prepublish-panel/prepublish-panel.tsx # Conflicts: # packages/js/product-editor/src/components/prepublish-panel/style.scss * Add show-prepublish-checks hook * Refactor prepublish panel button visiblity # Conflicts: # packages/js/product-editor/src/components/header/header.tsx # Conflicts: # packages/js/product-editor/src/components/header/header.tsx * Fix footer styles * Add changelogs * Add content div * Fix styles # Conflicts: # packages/js/product-editor/src/components/prepublish-panel/style.scss * Rename recorded action * Fix styles * Hide panel after unchecking option * Improve resolving * Add new E2E test for merchant transforming classic cart to cart block (#44926) * Update the monorepo-utils gitignore to only include index.js and its license file. (#44932) * Fixed `@woocommerce/plugin-woocommerce` Watch (#44930) By default `nodemon` only watches for JS file changes. This expands the config so that it watch the file extensions that are actually produced by builds. * Update core package.json to remove nightly ci config (#45096) * Update core package.json to remove nightly ci config * Add changefile(s) from automation for the following project(s): woocommerce --------- Co-authored-by: github-actions <github-actions@github.com> * Update blocks build message (#44811) * Update blocks build message * Add changefile(s) from automation for the following project(s): woocommerce * Update plugins/woocommerce/src/Blocks/Domain/Bootstrap.php Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> * Update plugins/woocommerce/src/Blocks/Domain/Bootstrap.php Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> * [CYS on Core] Update the themes list on the intro screen (#44822) * Update themes list on core. Update the themes data and remove hardcoded reference to free themes. * Update styles for the Free, Paid and active cards. * Add the color palletes to TT4 theme. * Update the references for default and core themes. * Add changefile(s) from automation for the following project(s): woocommerce * Update the link to TT4 theme * Update default value for price. --------- Co-authored-by: github-actions <github-actions@github.com> --------- Co-authored-by: Veljko V <veljano@yahoo.com> Co-authored-by: jonathansadowski <jonathansadowski@users.noreply.github.com> Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Roy Ho <roykho77@gmail.com> Co-authored-by: Patricia Hillebrandt <patriciahillebrandt@gmail.com>

octaedro self-assigned this Feb 13, 2024

octaedro force-pushed the add/43707_show_prepublish_checks_section branch from a66650c to 846e61f Compare February 14, 2024 19:24

octaedro requested a review from a team February 14, 2024 19:25

octaedro added focus: new product ux revamped product management experience team: Mothra labels Feb 14, 2024

octaedro marked this pull request as ready for review February 14, 2024 19:25

github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 14, 2024

octaedro marked this pull request as draft February 14, 2024 19:45

octaedro force-pushed the add/43707_show_prepublish_checks_section branch from 6bd9ef2 to 0fc312c Compare February 15, 2024 12:50

octaedro marked this pull request as ready for review February 15, 2024 12:51

octaedro force-pushed the add/43707_show_prepublish_checks_section branch from 9b7f43b to 8f6d1d9 Compare February 16, 2024 19:03

octaedro marked this pull request as draft February 21, 2024 14:43

octaedro marked this pull request as ready for review February 21, 2024 16:00

octaedro force-pushed the add/43707_show_prepublish_checks_section branch from 014c701 to e88dfa8 Compare February 23, 2024 14:16

mdperez86 approved these changes Feb 23, 2024

View reviewed changes

octaedro added 11 commits February 23, 2024 13:50

Add show-prepublish-checks-section

e9bd8c3

# Conflicts: # packages/js/product-editor/src/components/prepublish-panel/prepublish-panel.tsx # Conflicts: # packages/js/product-editor/src/components/prepublish-panel/style.scss

Add show-prepublish-checks hook

d7dcc7d

Refactor prepublish panel button visiblity

fffb1bd

# Conflicts: # packages/js/product-editor/src/components/header/header.tsx # Conflicts: # packages/js/product-editor/src/components/header/header.tsx

Fix footer styles

9e5a6ab

Add changelogs

440c87b

Add content div

a95994e

Fix styles

c6846a6

# Conflicts: # packages/js/product-editor/src/components/prepublish-panel/style.scss

Rename recorded action

a0c790d

Fix styles

91abde7

Hide panel after unchecking option

14052ae

Improve resolving

87c8ed0

octaedro force-pushed the add/43707_show_prepublish_checks_section branch from 1c271df to 87c8ed0 Compare February 23, 2024 16:53

Add new E2E test for merchant transforming classic cart to cart block (…

f705c21

…#44926)

jonathansadowski and others added 5 commits February 26, 2024 00:38

Update the monorepo-utils gitignore to only include index.js and its …

a37eecd

…license file. (#44932)

Fixed @woocommerce/plugin-woocommerce Watch (#44930)

b6f9aa5

By default `nodemon` only watches for JS file changes. This expands the config so that it watch the file extensions that are actually produced by builds.

Update core package.json to remove nightly ci config (#45096)

9ee9594

* Update core package.json to remove nightly ci config * Add changefile(s) from automation for the following project(s): woocommerce --------- Co-authored-by: github-actions <github-actions@github.com>

github-actions bot added focus: e2e tests Issues related to e2e tests tool: monorepo infrastructure Issues and PRs related to monorepo tooling. labels Feb 26, 2024

octaedro merged commit 3d3f6d6 into trunk Feb 26, 2024
63 checks passed

octaedro deleted the add/43707_show_prepublish_checks_section branch February 26, 2024 11:38

github-actions bot added this to the 8.8.0 milestone Feb 26, 2024

github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `Always show pre-publish checks` checkbox #44595

Add `Always show pre-publish checks` checkbox #44595

octaedro commented Feb 13, 2024 •

edited

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024 •

edited

mdperez86 left a comment

Add Always show pre-publish checks checkbox #44595

Add Always show pre-publish checks checkbox #44595

Conversation

octaedro commented Feb 13, 2024 • edited

Submission Review Guidelines:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Changelog entry

Significance

Type

Message

Comment

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024 • edited

Test Results Summary

mdperez86 left a comment

Choose a reason for hiding this comment

Add `Always show pre-publish checks` checkbox #44595

Add `Always show pre-publish checks` checkbox #44595

octaedro commented Feb 13, 2024 •

edited

github-actions bot commented Feb 14, 2024 •

edited