[CYS on Core] Update the themes list on the intro screen #44822

nefeline · 2024-02-20T22:56:14Z

Submission Review Guidelines:

I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have reviewed my code for security best practices.
Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Ensure the following themes are listed on the Intro Screen for the implementation on core:

Add the "Paid" badge
Add the color palette for the TT4 theme. The color palettes for the other themes will be added as part of a separate PR.

PS: there's also a pending change regarding a copy after the user clicks on each one of these themes, this change is planned to be implemented on a separate PR.

Views

Core (with one of the themes active)

Core (with none of those themes active)

WooExpress (unchanged)

Closes #44609

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Enable the WooCommerce Beta Tester plugin if you don't have it enabled yet
On your Dashboard, head over to Tools > WCA Test Helper > Features and enable the customize-store
Access your Dashboard and head over to WooCommerce > Home
Click on the "Customize Your Store" button
Make sure you see the following themes listed:

Click on each one of the themes and make sure the links are all correct.
Repeat steps 3 to 5 on WooExpress, and at that end, make sure the following themes are listed:

Changelog entry

Automatically create a changelog entry from the details below.

Significance

Patch
Minor
Major

Type

Fix - Fixes an existing bug
Add - Adds functionality
Update - Update existing functionality
Dev - Development related task
Tweak - A minor adjustment to the codebase
Performance - Address performance issues
Enhancement - Improvement to existing functionality

Message

Update the themes list on the Customize Your Store intro screen.

Comment

…ed reference to free themes.

github-actions · 2024-02-20T23:14:28Z

Test Results Summary

Commit SHA: f0662c0

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 39s
E2E Tests	337	0	0	8	0	345	7m 11s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

github-actions · 2024-02-21T17:38:39Z

Hi @albarin, @roykho,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

…mmerce

plugins/woocommerce/src/Admin/API/OnboardingThemes.php

roykho

The themes show up nicely with correct links now. I just left a comment. Also I did not test Woo Express (not sure how to set that up? If you wanna to show me I can test that too).

plugins/woocommerce-admin/client/customize-store/intro/theme-card.tsx

nefeline · 2024-02-23T22:09:42Z

The themes show up nicely with correct links now. I just left a comment. Also I did not test Woo Express (not sure how to set that up? If you wanna to show me I can test that too).

Thanks Roy 🙏 ! All good, I can ask @albarin to take a look on WooExpress as this setup can take some time, but if you really want to test it on that env, please let me know & I'll share the dets. Alba, I hope you don't mind I tagged you on the review here :)

roykho

Yes if you could please pass me any information on how to setup Woo Express for testing locally that would be great as then I can test future PRs (I did check FG but didn't find anything or I must of missed something). With that said, it doesn't have to be a blocker for this PR from my side.

nefeline · 2024-02-25T19:05:49Z

@roykho regarding:

Yes if you could please pass me any information on how to setup Woo Express for testing locally that would be great as then I can test future PRs (I did check FG but didn't find anything or I must of missed something).

Absolutely! Here you go: pdibGW-2pG-p2

…-the-intro-screen

nefeline · 2024-02-25T20:01:13Z

@albarin in order to expedite the call for testing, I went ahead and merged this one, but if you find any oddities on WooExpress, please let me know & I'll open a new PR to address any problems 🙏

* Update themes list on core. Update the themes data and remove hardcoded reference to free themes. * Update styles for the Free, Paid and active cards. * Add the color palletes to TT4 theme. * Update the references for default and core themes. * Add changefile(s) from automation for the following project(s): woocommerce * Update the link to TT4 theme * Update default value for price. --------- Co-authored-by: github-actions <github-actions@github.com>

* Add show-prepublish-checks-section # Conflicts: # packages/js/product-editor/src/components/prepublish-panel/prepublish-panel.tsx # Conflicts: # packages/js/product-editor/src/components/prepublish-panel/style.scss * Add show-prepublish-checks hook * Refactor prepublish panel button visiblity # Conflicts: # packages/js/product-editor/src/components/header/header.tsx # Conflicts: # packages/js/product-editor/src/components/header/header.tsx * Fix footer styles * Add changelogs * Add content div * Fix styles # Conflicts: # packages/js/product-editor/src/components/prepublish-panel/style.scss * Rename recorded action * Fix styles * Hide panel after unchecking option * Improve resolving * Add new E2E test for merchant transforming classic cart to cart block (#44926) * Update the monorepo-utils gitignore to only include index.js and its license file. (#44932) * Fixed `@woocommerce/plugin-woocommerce` Watch (#44930) By default `nodemon` only watches for JS file changes. This expands the config so that it watch the file extensions that are actually produced by builds. * Update core package.json to remove nightly ci config (#45096) * Update core package.json to remove nightly ci config * Add changefile(s) from automation for the following project(s): woocommerce --------- Co-authored-by: github-actions <github-actions@github.com> * Update blocks build message (#44811) * Update blocks build message * Add changefile(s) from automation for the following project(s): woocommerce * Update plugins/woocommerce/src/Blocks/Domain/Bootstrap.php Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> * Update plugins/woocommerce/src/Blocks/Domain/Bootstrap.php Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> * [CYS on Core] Update the themes list on the intro screen (#44822) * Update themes list on core. Update the themes data and remove hardcoded reference to free themes. * Update styles for the Free, Paid and active cards. * Add the color palletes to TT4 theme. * Update the references for default and core themes. * Add changefile(s) from automation for the following project(s): woocommerce * Update the link to TT4 theme * Update default value for price. --------- Co-authored-by: github-actions <github-actions@github.com> --------- Co-authored-by: Veljko V <veljano@yahoo.com> Co-authored-by: jonathansadowski <jonathansadowski@users.noreply.github.com> Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Roy Ho <roykho77@gmail.com> Co-authored-by: Patricia Hillebrandt <patriciahillebrandt@gmail.com>

* Update themes list on core. Update the themes data and remove hardcoded reference to free themes. * Update styles for the Free, Paid and active cards. * Add the color palletes to TT4 theme. * Update the references for default and core themes. * Add changefile(s) from automation for the following project(s): woocommerce * Update the link to TT4 theme * Update default value for price. --------- Co-authored-by: github-actions <github-actions@github.com>

* Add show-prepublish-checks-section # Conflicts: # packages/js/product-editor/src/components/prepublish-panel/prepublish-panel.tsx # Conflicts: # packages/js/product-editor/src/components/prepublish-panel/style.scss * Add show-prepublish-checks hook * Refactor prepublish panel button visiblity # Conflicts: # packages/js/product-editor/src/components/header/header.tsx # Conflicts: # packages/js/product-editor/src/components/header/header.tsx * Fix footer styles * Add changelogs * Add content div * Fix styles # Conflicts: # packages/js/product-editor/src/components/prepublish-panel/style.scss * Rename recorded action * Fix styles * Hide panel after unchecking option * Improve resolving * Add new E2E test for merchant transforming classic cart to cart block (#44926) * Update the monorepo-utils gitignore to only include index.js and its license file. (#44932) * Fixed `@woocommerce/plugin-woocommerce` Watch (#44930) By default `nodemon` only watches for JS file changes. This expands the config so that it watch the file extensions that are actually produced by builds. * Update core package.json to remove nightly ci config (#45096) * Update core package.json to remove nightly ci config * Add changefile(s) from automation for the following project(s): woocommerce --------- Co-authored-by: github-actions <github-actions@github.com> * Update blocks build message (#44811) * Update blocks build message * Add changefile(s) from automation for the following project(s): woocommerce * Update plugins/woocommerce/src/Blocks/Domain/Bootstrap.php Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> * Update plugins/woocommerce/src/Blocks/Domain/Bootstrap.php Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> * [CYS on Core] Update the themes list on the intro screen (#44822) * Update themes list on core. Update the themes data and remove hardcoded reference to free themes. * Update styles for the Free, Paid and active cards. * Add the color palletes to TT4 theme. * Update the references for default and core themes. * Add changefile(s) from automation for the following project(s): woocommerce * Update the link to TT4 theme * Update default value for price. --------- Co-authored-by: github-actions <github-actions@github.com> --------- Co-authored-by: Veljko V <veljano@yahoo.com> Co-authored-by: jonathansadowski <jonathansadowski@users.noreply.github.com> Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Roy Ho <roykho77@gmail.com> Co-authored-by: Patricia Hillebrandt <patriciahillebrandt@gmail.com>

Update themes list on core. Update the themes data and remove hardcod…

0a697b1

…ed reference to free themes.

nefeline linked an issue Feb 20, 2024 that may be closed by this pull request

[CYS on Core] Update the themes list on the intro screen #44609

Closed

github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 20, 2024

Update styles for the Free, Paid and active cards.

f38c711

nefeline self-assigned this Feb 20, 2024

nefeline added type: enhancement The issue is a request for an enhancement. focus: customize-your-store Issues related to the Customize Your Store onboarding flow. labels Feb 20, 2024

nefeline added 2 commits February 21, 2024 00:26

Add the color palletes to TT4 theme.

2cb87af

Update the references for default and core themes.

a08dc99

nefeline marked this pull request as ready for review February 21, 2024 17:38

woocommercebot requested review from a team and roykho and removed request for a team February 21, 2024 17:38

nefeline requested a review from albarin February 21, 2024 17:38

Add changefile(s) from automation for the following project(s): wooco…

746e245

…mmerce

roykho reviewed Feb 21, 2024

View reviewed changes

plugins/woocommerce/src/Admin/API/OnboardingThemes.php Outdated Show resolved Hide resolved

Update the link to TT4 theme

183d011

nefeline requested a review from roykho February 23, 2024 09:18

roykho reviewed Feb 23, 2024

View reviewed changes

plugins/woocommerce-admin/client/customize-store/intro/theme-card.tsx Outdated Show resolved Hide resolved

Update default value for price.

5368d57

roykho approved these changes Feb 23, 2024

View reviewed changes

Merge branch 'trunk' into 44609-cys-on-core-update-the-themes-list-on…

124db88

…-the-intro-screen

nefeline enabled auto-merge (squash) February 25, 2024 19:07

nefeline added 2 commits February 25, 2024 21:35

Clear out lint error.

eb3b4d7

Update scss

f0662c0

nefeline merged commit e741999 into trunk Feb 25, 2024
31 checks passed

nefeline deleted the 44609-cys-on-core-update-the-themes-list-on-the-intro-screen branch February 25, 2024 19:56

github-actions bot added this to the 8.8.0 milestone Feb 25, 2024

github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CYS on Core] Update the themes list on the intro screen #44822

[CYS on Core] Update the themes list on the intro screen #44822

nefeline commented Feb 20, 2024 •

edited

github-actions bot commented Feb 20, 2024 •

edited

github-actions bot commented Feb 21, 2024 •

edited

roykho left a comment

nefeline commented Feb 23, 2024

roykho left a comment

nefeline commented Feb 25, 2024

nefeline commented Feb 25, 2024

[CYS on Core] Update the themes list on the intro screen #44822

[CYS on Core] Update the themes list on the intro screen #44822

Conversation

nefeline commented Feb 20, 2024 • edited

Submission Review Guidelines:

Changes proposed in this Pull Request:

Views

Core (with one of the themes active)

Core (with none of those themes active)

WooExpress (unchanged)

How to test the changes in this Pull Request:

Changelog entry

Significance

Type

Message

Comment

github-actions bot commented Feb 20, 2024 • edited

Test Results Summary

github-actions bot commented Feb 21, 2024 • edited

roykho left a comment

Choose a reason for hiding this comment

nefeline commented Feb 23, 2024

roykho left a comment

Choose a reason for hiding this comment

nefeline commented Feb 25, 2024

nefeline commented Feb 25, 2024

nefeline commented Feb 20, 2024 •

edited

github-actions bot commented Feb 20, 2024 •

edited

github-actions bot commented Feb 21, 2024 •

edited