Add new E2E test for merchant transforming classic cart to cart block #44926

veljkho · 2024-02-23T15:11:24Z

Submission Review Guidelines:

I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have reviewed my code for security best practices.
Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Added merchant test for transforming classic to block-based cart.

Closes # 637

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Checkout this branch locally
Execute: pnpm test:e2e-pw ./tests/e2e-pw/tests/merchant/create-cart-block.spec.js
Make sure it pass

Changelog entry

Automatically create a changelog entry from the details below.

Significance

Patch
Minor
Major

Type

Fix - Fixes an existing bug
Add - Adds functionality
Update - Update existing functionality
Dev - Development related task
Tweak - A minor adjustment to the codebase
Performance - Address performance issues
Enhancement - Improvement to existing functionality

Message

Comment

github-actions · 2024-02-23T15:30:37Z

Hi @adimoldovan, @woocommerce/solaris

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

github-actions · 2024-02-23T15:36:02Z

Test Results Summary

Commit SHA: 62e1d17

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 37s
E2E Tests	291	0	0	54	0	345	7m 38s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

adimoldovan

Thanks for adding this test @veljkho.
It tested well to me, but I can you please take care of the page not being cleaned-up/unique?

adimoldovan · 2024-02-23T16:50:16Z

plugins/woocommerce/tests/e2e-pw/tests/merchant/create-cart-block.spec.js

+const { admin } = require( '../../test-data/data' );
+const { closeWelcomeModal } = require( '../../utils/editor' );
+
+const transformedCartBlockTitle = 'Transformed Cart';


Can you use an unique page name, to ensure the right page gets tested on test re-runs?

Suggested change

const transformedCartBlockTitle = 'Transformed Cart';

const transformedCartBlockTitle = `Transformed Cart ${ Date.now() }`;

Thanks for reviewing @adimoldovan , added as suggested. 👍

adimoldovan · 2024-02-23T16:51:15Z

plugins/woocommerce/tests/e2e-pw/tests/merchant/create-cart-block.spec.js

+	test.afterAll( async ( { baseURL } ) => {
+		const base64auth = Buffer.from(
+			`${ admin.username }:${ admin.password }`
+		).toString( 'base64' );
+		const wpApi = await request.newContext( {
+			baseURL: `${ baseURL }/wp-json/wp/v2/`,
+			extraHTTPHeaders: {
+				Authorization: `Basic ${ base64auth }`,
+			},
+		} );
+		let response = await wpApi.get( `pages` );
+		const allPages = await response.json();
+		await allPages.forEach( async ( page ) => {
+			if ( page.title.rendered === transformedCartBlockTitle ) {
+				response = await wpApi.delete( `pages/${ page.id }`, {
+					data: {
+						force: true,
+					},
+				} );
+			}
+		} );
+	} );


The page deletion is not working, can you please make it work or remove the code if not?

Sure, it was removed in a new commit.

adimoldovan

Thanks @veljkho, it looks good!

…#44926)

* Add show-prepublish-checks-section # Conflicts: # packages/js/product-editor/src/components/prepublish-panel/prepublish-panel.tsx # Conflicts: # packages/js/product-editor/src/components/prepublish-panel/style.scss * Add show-prepublish-checks hook * Refactor prepublish panel button visiblity # Conflicts: # packages/js/product-editor/src/components/header/header.tsx # Conflicts: # packages/js/product-editor/src/components/header/header.tsx * Fix footer styles * Add changelogs * Add content div * Fix styles # Conflicts: # packages/js/product-editor/src/components/prepublish-panel/style.scss * Rename recorded action * Fix styles * Hide panel after unchecking option * Improve resolving * Add new E2E test for merchant transforming classic cart to cart block (#44926) * Update the monorepo-utils gitignore to only include index.js and its license file. (#44932) * Fixed `@woocommerce/plugin-woocommerce` Watch (#44930) By default `nodemon` only watches for JS file changes. This expands the config so that it watch the file extensions that are actually produced by builds. * Update core package.json to remove nightly ci config (#45096) * Update core package.json to remove nightly ci config * Add changefile(s) from automation for the following project(s): woocommerce --------- Co-authored-by: github-actions <github-actions@github.com> * Update blocks build message (#44811) * Update blocks build message * Add changefile(s) from automation for the following project(s): woocommerce * Update plugins/woocommerce/src/Blocks/Domain/Bootstrap.php Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> * Update plugins/woocommerce/src/Blocks/Domain/Bootstrap.php Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> * [CYS on Core] Update the themes list on the intro screen (#44822) * Update themes list on core. Update the themes data and remove hardcoded reference to free themes. * Update styles for the Free, Paid and active cards. * Add the color palletes to TT4 theme. * Update the references for default and core themes. * Add changefile(s) from automation for the following project(s): woocommerce * Update the link to TT4 theme * Update default value for price. --------- Co-authored-by: github-actions <github-actions@github.com> --------- Co-authored-by: Veljko V <veljano@yahoo.com> Co-authored-by: jonathansadowski <jonathansadowski@users.noreply.github.com> Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Roy Ho <roykho77@gmail.com> Co-authored-by: Patricia Hillebrandt <patriciahillebrandt@gmail.com>

…#44926)

* Add show-prepublish-checks-section # Conflicts: # packages/js/product-editor/src/components/prepublish-panel/prepublish-panel.tsx # Conflicts: # packages/js/product-editor/src/components/prepublish-panel/style.scss * Add show-prepublish-checks hook * Refactor prepublish panel button visiblity # Conflicts: # packages/js/product-editor/src/components/header/header.tsx # Conflicts: # packages/js/product-editor/src/components/header/header.tsx * Fix footer styles * Add changelogs * Add content div * Fix styles # Conflicts: # packages/js/product-editor/src/components/prepublish-panel/style.scss * Rename recorded action * Fix styles * Hide panel after unchecking option * Improve resolving * Add new E2E test for merchant transforming classic cart to cart block (#44926) * Update the monorepo-utils gitignore to only include index.js and its license file. (#44932) * Fixed `@woocommerce/plugin-woocommerce` Watch (#44930) By default `nodemon` only watches for JS file changes. This expands the config so that it watch the file extensions that are actually produced by builds. * Update core package.json to remove nightly ci config (#45096) * Update core package.json to remove nightly ci config * Add changefile(s) from automation for the following project(s): woocommerce --------- Co-authored-by: github-actions <github-actions@github.com> * Update blocks build message (#44811) * Update blocks build message * Add changefile(s) from automation for the following project(s): woocommerce * Update plugins/woocommerce/src/Blocks/Domain/Bootstrap.php Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> * Update plugins/woocommerce/src/Blocks/Domain/Bootstrap.php Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> * [CYS on Core] Update the themes list on the intro screen (#44822) * Update themes list on core. Update the themes data and remove hardcoded reference to free themes. * Update styles for the Free, Paid and active cards. * Add the color palletes to TT4 theme. * Update the references for default and core themes. * Add changefile(s) from automation for the following project(s): woocommerce * Update the link to TT4 theme * Update default value for price. --------- Co-authored-by: github-actions <github-actions@github.com> --------- Co-authored-by: Veljko V <veljano@yahoo.com> Co-authored-by: jonathansadowski <jonathansadowski@users.noreply.github.com> Co-authored-by: Christopher Allford <6451942+ObliviousHarmony@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Roy Ho <roykho77@gmail.com> Co-authored-by: Patricia Hillebrandt <patriciahillebrandt@gmail.com>

Add e2e merchant test transforming cart

9f0bf47

veljkho self-assigned this Feb 23, 2024

veljkho added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 23, 2024

github-actions bot added the focus: e2e tests Issues related to e2e tests label Feb 23, 2024

veljkho changed the title ~~Add e2e merchant test transforming cart~~ Add new E2E test for merchant transforming classic cart to cart block Feb 23, 2024

veljkho requested review from a team February 23, 2024 15:30

adimoldovan requested changes Feb 23, 2024

View reviewed changes

Update page title and remove afterAll

62e1d17

veljkho requested a review from adimoldovan February 23, 2024 17:36

adimoldovan approved these changes Feb 23, 2024

View reviewed changes

adimoldovan merged commit 7018f2b into trunk Feb 23, 2024
34 checks passed

adimoldovan deleted the e2e/add/merchant-cart-block branch February 23, 2024 17:51

github-actions bot added this to the 8.8.0 milestone Feb 23, 2024

github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 23, 2024

octaedro pushed a commit that referenced this pull request Feb 26, 2024

Add new E2E test for merchant transforming classic cart to cart block (…

f705c21

…#44926)

alopezari added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 26, 2024

Konamiman pushed a commit that referenced this pull request Mar 13, 2024

Add new E2E test for merchant transforming classic cart to cart block (…

f04ecbf

…#44926)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new E2E test for merchant transforming classic cart to cart block #44926

Add new E2E test for merchant transforming classic cart to cart block #44926

veljkho commented Feb 23, 2024

github-actions bot commented Feb 23, 2024 •

edited

github-actions bot commented Feb 23, 2024 •

edited

adimoldovan left a comment

adimoldovan Feb 23, 2024

veljkho Feb 23, 2024

adimoldovan Feb 23, 2024

veljkho Feb 23, 2024

adimoldovan left a comment

	const transformedCartBlockTitle = 'Transformed Cart';
	const transformedCartBlockTitle = `Transformed Cart ${ Date.now() }`;

Add new E2E test for merchant transforming classic cart to cart block #44926

Add new E2E test for merchant transforming classic cart to cart block #44926

Conversation

veljkho commented Feb 23, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Changelog entry

Significance

Type

Message

Comment

github-actions bot commented Feb 23, 2024 • edited

github-actions bot commented Feb 23, 2024 • edited

Test Results Summary

adimoldovan left a comment

Choose a reason for hiding this comment

adimoldovan Feb 23, 2024

Choose a reason for hiding this comment

veljkho Feb 23, 2024

Choose a reason for hiding this comment

adimoldovan Feb 23, 2024

Choose a reason for hiding this comment

veljkho Feb 23, 2024

Choose a reason for hiding this comment

adimoldovan left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 23, 2024 •

edited

github-actions bot commented Feb 23, 2024 •

edited