Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty prefix #4

Closed
cvle opened this issue Sep 14, 2016 · 4 comments
Closed

Allow empty prefix #4

cvle opened this issue Sep 14, 2016 · 4 comments

Comments

@cvle
Copy link

cvle commented Sep 14, 2016

Setting to an empty string still results in the default prefix.
I was expecting it to disable prefix completely.

@wooorm
Copy link
Owner

wooorm commented Sep 14, 2016

Hi, @cvle! Thanks for raising this.

This is mainly a port of highlight.js. Do you know if that has the same problem, or is there a difference in behaviour between these?

@cvle
Copy link
Author

cvle commented Sep 14, 2016

I am not familiar with hightlight.js so I don't know. I mainly use your library (and it works great) ;-)

@wooorm
Copy link
Owner

wooorm commented Sep 14, 2016

Great, thanks! But this is a fork, so I’ll only do what they do (albeit virtualised), so if you want it here it needs to be in highlight.js too.

@wooorm
Copy link
Owner

wooorm commented Sep 17, 2016

I just checked with highlight.js and as they have global configuration, and lowlight differs in that. I’m OK with doing this!

@wooorm wooorm closed this as completed in 6d9bab7 Sep 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants