Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change prismjs to carat range? #33

Closed
karlhorky opened this issue Aug 12, 2020 · 3 comments
Closed

Change prismjs to carat range? #33

karlhorky opened this issue Aug 12, 2020 · 3 comments

Comments

@karlhorky
Copy link
Contributor

Hi @wooorm !

Maybe going forward, you would consider changing to a carat version range for prismjs?

It would help a lot for projects stuck with older dependencies which have refractor as a transitive dep (especially when things like security vulnerabilities with prismjs happen).

Anyway, thanks for the consideration!

@wooorm
Copy link
Owner

wooorm commented Aug 12, 2020

Hi Karl! 👋

We have Prism as a dep for its core. Basically hidden internals. Loosening the range will cause stuff to break. I find preventing everything from exploding more important than older dependencies. Refractor also has a track record of updating fast after Prism updates, and if you use refractor itself with a loose range, you’ll also get Prism updates.

The security vulnerability did not affect anyone using refractor, as we don’t support plugins. If there is an issue, it’s with Dependabot falsely claiming there was one 🤷‍♂️

@wooorm wooorm closed this as completed Aug 12, 2020
@karlhorky
Copy link
Contributor Author

Ok, understandable. Thanks for the answer :)

@wooorm
Copy link
Owner

wooorm commented Aug 12, 2020

No problem, thanks for understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants