Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types issue #968

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fix types issue #968

merged 1 commit into from
Mar 1, 2024

Conversation

justin-tay
Copy link
Contributor

Closes #967

@wopian
Copy link
Owner

wopian commented Feb 28, 2024

Does this need to be added for all the exports?

I imagine kitsu-core exports will also need to be updated if not respecting the top-level types field is becoming spec for modern node(-like) environments for exports

Copy link

codeclimate bot commented Feb 28, 2024

Code Climate has analyzed commit dfae94d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@wopian wopian merged commit 042f5b0 into wopian:master Mar 1, 2024
12 checks passed
@wopian
Copy link
Owner

wopian commented Mar 1, 2024

Thank you! A new release will be cut later today.

@tompato
Copy link

tompato commented Mar 12, 2024

Thank you! A new release will be cut later today.

Sorry to resurrect this, but could we get a release for this fix? :)

@wopian
Copy link
Owner

wopian commented Mar 14, 2024

Apologies for the delay. This has been released as 10.1.4 including the same change applied to the kitsu-core exports.

Please note that the repository had a force-push to amend the PR title to conform to our commit naming scheme (to be tracked as a change in changelog and version picking)

Changelog: https://github.com/wopian/kitsu/releases/tag/v10.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with types
3 participants