Serialising relationship arrays is not handled

[duk3luk3]

Trying to post this with kitsu:

    container_users = container_users.map(x => ({
        id: x,
        type: 'users'
    }));

    api.create('container', {
        name: container_name,
        'creator': {
            'id': container_creator,
            'type': 'users'
        },
        'host': {
            'id': container_host,
            'type': 'hosts'
        },
        'users': container_users
    }).then(res => console.log(res)
    ).catch((reason) => console.log(reason));

results in this being POSTed:

{
  "data": {
    "type": "containers",
    "attributes": {
      "name": "testcontainer3",
      "users": [
        {
          "id": 1,
          "type": "users"
        },
        {
          "id": 2,
          "type": "users"
        }
      ]
    },
    "relationships": {
      "creator": {
        "data": {
          "id": 1,
          "type": "users"
        }
      },
      "host": {
        "data": {
          "id": 1,
          "type": "hosts"
        }
      }
    }
  },
  "headers": {
    "Authorization": "foobar",
    "accept": "application\/vnd.api+json",
    "content-type": "application\/vnd.api+json"
  }
}

it puts users into attributes instead of relationships, where it should go.

This is because the relationship test in serialise.js does not test for arrays.

[duk3luk3]

Is this the right approach to fix this? duk3luk3@3f6ea89

[wopian]

Not quite. Will need to handle objects and arrays separately, since that check will only verify the first item in the array is valid and the contents of the if block will fail with arrays.

[duk3luk3]

OK, I've backed out that commit and just added a spec for now so I can make sure I understand fully what needs to be changed (This is my first real JSONAPI rodeo).

I made a PR so I can run the tests without setting them up myself.

Please let me know if the spec needs fixing. It fails as expected in the appveyor build: https://ci.appveyor.com/project/wopian/kitsu/build/519/job/h8rp731s63chvols