Gutenberg/integrate release 1.23.0

[mchowning]

Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1924

Changes

wordpress-mobile/gutenberg-mobile#1914 Fix menu item width inside the inserter
wordpress-mobile/gutenberg-mobile#1918 Correct add icon appearance
wordpress-mobile/gutenberg-mobile#1904 Removing DEV flag for Image block size options
wordpress-mobile/gutenberg-mobile#1879 Fix link button on Rich Text
wordpress-mobile/gutenberg-mobile#1895 Image upload preview incorrect on id conflict
wordpress-mobile/gutenberg-mobile#1616 Button Block
wordpress-mobile/gutenberg-mobile#1866 Enable Button block in production
wordpress-mobile/gutenberg-mobile#1855 Enable gallery upload options in production
wordpress-mobile/gutenberg-mobile#1837 Correct layout within bottom-sheet
wordpress-mobile/gutenberg-mobile#1834 Replace Slider with Stepper for columns settings on Gallery block
wordpress-mobile/gutenberg-mobile#1859 Feat: refine block borders
wordpress-mobile/gutenberg-mobile#1872 Fix layout issue in Shortcode
wordpress-mobile/gutenberg-mobile#1850 Feat: Open Group block for production
wordpress-mobile/gutenberg-mobile#1838 Adjust vertical margins in InnerBlock
wordpress-mobile/gutenberg-mobile#1798 Fix gallery size labels

Changes - After the Release Branch was Cut

wordpress-mobile/gutenberg-mobile#1894 Fix inserter
wordpress-mobile/gutenberg-mobile#1930 Make sure strong tags are removed from title

To Test

Smoke test the app and report if all OK
Please try the items in the changelog above and report the test outcome of each one that you tested

PR submission checklist

• I have considered adding unit tests where possible.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

You can test the changes on this Pull Request by downloading the APK here.

[maxme]

Smoke tested on Vanilla Debug:

• Fix menu item width inside the inserter ✅
• Correct add icon appearance ✅
• Removing DEV flag for Image block size options ✅
• Fix link button on Rich Text ✅
• Image upload preview incorrect on id conflict ? (I didn't try to repro)
• Button Block (now in production) ✅
• Enable Button block in production ✅
• Enable gallery upload options in production ✅(Yayyyy!!)
• Correct layout within bottom-sheet ✅(I found a weird behavior in landscape mode when tapping the "next" button on the virtual keyboard, I'll double check)
• Replace Slider with Stepper for columns settings on Gallery block ✅
• Feat: refine block borders ✅
• Fix layout issue in Shortcode ✅ (Shortcode was translated in French, looks wrong to me, I'll double check).
• Feat: Open Group block for production ✅ (Yayyyy!!!)
• Adjust vertical margins in InnerBlock ?
• Fix gallery size labels ✅

[Tug]

Smoke tested blocks in general (OK things first):

• Adding and removing blocks: OK

• Moving blocks up and down: OK

• Undo & redo: OK

• Paragraph block, enter to create a new one: OK

• Paragraph block, add link to text: OK, however selection was shifted one character to the right after that.

• Paragraph block, add remove bold/italic: OK

• MediaText: upload image from library and edit text while uploading: OK

• Navigating the hierachy of blocks: OK, though we still have some scroll issues and focus delay when selecting blocks

• Inserter: OK

• Inserter long press: OK

• Switch to HTML, edit, and back to visual: OK

• Heading block: OK

• Quote block: OK

• Image block: OK

• Video block: OK

• Galery block: OK

• Group block: OK

• More block: OK

• Seperator block: OK

• Spacer block: OK

• Shortcode block: OK

• Page break block: OK

• List block and Preformatted block: noticed some text disappear when taping enter and immediately typing text, this text disappears after two seconds and only then what you type does not disappear (tested on the debug mode, so it might not be visible in prod)

• MediaText/Paragraph: Focusing on a paragraph inside a MediaText block and taping enter too quickly will create a new paragraph above instead of underneath. This is because the cursor can appear at the beginning of the text for a shortwhile (Even though you tapped in the middle).

• Paragraph: removing an empty paragraph with backspace might cause an aztec error when the cursor is brought at the end of a previous paragraph block with content:

Error while updating property 'text' of a view managed by RTCAztecView

null

setSpan(21 ... 21) ends beyond length 20

I don't think those are regressions though, I might run a production build to see the difference

[mchowning]

I tested all the changes with the latest code (my gutenberg-mobile comment identifies the specific changes I tested) and everything looks good to me.

With respect to the issues that @Tug noted...

List block and Preformatted block: noticed some text disappear when taping enter and immediately typing text, this text disappears after two seconds and only then what you type does not disappear (tested on the debug mode, so it might not be visible in prod)

I agree that this isn't a regression. Also, I can reproduce it in prod, but it's certainly more difficult. I've opened an issue to track this: wordpress-mobile/gutenberg-mobile#1941

MediaText/Paragraph: Focusing on a paragraph inside a MediaText block and taping enter too quickly will create a new paragraph above instead of underneath. This is because the cursor can appear at the beginning of the text for a shortwhile (Even though you tapped in the middle).

I could not recreate this issue using a physical device and it was very difficult for me to reproduce on an emulator running a release build, so I do not think this is an issue that needs to be fixed for the release.

Paragraph: removing an empty paragraph with backspace might cause an aztec error when the cursor is brought at the end of a previous paragraph block with content

I have not been able to recreate this issue. I don't doubt that it happens, but it appears to be quite hard to recreate.

[cameronvoell]

I agree with the conclusions @mchowning came to in his comment here about uncovered issues that do no appear to be new.

I tested most of these changes already via wordpress-mobile/gutenberg-mobile#1924. I spent more time on the Android Specific wordpress-mobile/gutenberg-mobile#1895 Image upload preview incorrect on id conflict, and that fix looks good.

Approved!