Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with WebKitViewController not observing scroll view for edge appearance #23495

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Aug 13, 2024

Fixes #23493.

(yes, there is a bottom padding on this page)

Screenshot 2024-08-13 at 1 21 12 PM Screenshot 2024-08-13 at 1 21 18 PM

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 13, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23495-152ab0f
Version25.2
Bundle IDorg.wordpress.alpha
Commit152ab0f
App Center BuildWPiOS - One-Offs #10482
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 13, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23495-152ab0f
Version25.2
Bundle IDcom.jetpack.alpha
Commit152ab0f
App Center Buildjetpack-installable-builds #9522
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean requested a review from crazytonyli August 14, 2024 12:32
@geriux
Copy link
Contributor

geriux commented Aug 14, 2024

Hey @kean 👋

Part of the issue seems to be solved, one thing I noticed is that when scrolling down, the background disappears.

ScreenRecording_08-14-2024.15-08-51_1.MP4

@kean kean marked this pull request as draft August 14, 2024 13:15
@kean
Copy link
Contributor Author

kean commented Aug 14, 2024

It's a separate issue with dark mode, but we need to disable the scroll edge appearance for this screen. I'm going to move it back to draft.

@kean kean force-pushed the fix/safe-area-domain-details branch from 076065f to 152ab0f Compare August 15, 2024 14:24
@kean kean marked this pull request as ready for review August 15, 2024 14:25
@kean
Copy link
Contributor Author

kean commented Aug 15, 2024

I switched to the standard approach for presenting wp.com pages in the app – presenting them in a modal screen with hardcoded .light color scheme:

Screenshot 2024-08-15 at 10 24 29 AM

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing this! 🚀

@kean kean added this pull request to the merge queue Aug 16, 2024
Merged via the queue into trunk with commit 46c0aaa Aug 16, 2024
24 checks passed
@kean kean deleted the fix/safe-area-domain-details branch August 16, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Domains - TabBar has a transparent background in the detail screen when using Dark Mode
3 participants