-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an issue with WebKitViewController not observing scroll view for edge appearance #23495
Conversation
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
Hey @kean 👋 Part of the issue seems to be solved, one thing I noticed is that when scrolling down, the background disappears. ScreenRecording_08-14-2024.15-08-51_1.MP4 |
It's a separate issue with dark mode, but we need to disable the scroll edge appearance for this screen. I'm going to move it back to draft. |
076065f
to
152ab0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for addressing this! 🚀
Fixes #23493.
(yes, there is a bottom padding on this page)
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: