-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a library/framework that can be used in the apps #163
Comments
Also, as we work on this one, let's make sure to keep @wordpress-mobile/platform-9 involved |
For the tasks mentioned, I believe that one sprint time is enough to have a first up-and-running Gutenberg inside the Native apps. But being aware that it will not be a definitive setup. Ideally we will give a working starting point open to evolve with future requests, realizations and issues that we might encounter. |
Android subtasks:
|
👋I have been spending some time taking the feature branches for integration in the WordPress apps for a spin. I'm very impressed with all the progress that has been made. One thing that I'd like to highlight is where the border between React Native and native should live. In my opinion, the ideal state would be that the apps are not required to have any React Native knowledge in order to consume Gutenberg. On the feature branch for WP Android, I discussed this with @hypest and he suggested I post here to capture these thoughts. |
Thanks for taking the time to check this out @jtreanor ! On WPiOS, my effort is to expose this header file to the WordPress app: It expose Gutenberg Editor as a UIView (similar to Aztec), a delegate to receive messages and methods to send messages to Gutenberg. And it doesn't have dependencies on React/React-Native. My intentions is to firstly try an integration via Cocoapods. Not sure if it's the best option, but it's the one I have found more info about. Waiting forward to know your opinion about it! |
Hey! These messages make me realise that I'm very late in answering a ping from @koke here: #195 (comment). :-) |
@etoledom That looks like a very promising approach and exactly what I was talking about above. CocoaPods in some form will probably make sense for consistency with the rest of the app. Its possible that distributing the pod as a binary may make sense, though I'm not too sure. I'll check out the in progress iOS integration some more and let you know if I have any thoughts. As @loremattei said, if there is anything specific we can help with, just let us know 😄 |
Thanks @jtreanor . I'd say that if there are any spare cycles you can donate, it's be awesome if you could try out what we said on Slack a few days back and is what @loremattei mentioned above: to have a way to rely on binary integration but still have source level integration for debug builds. |
I think we have completed this task on both platforms so, closing as "done". |
We want to be able to use gutenberg-mobile in the mobile apps (Android and iOS). More specifically we should be able to:
The text was updated successfully, but these errors were encountered: