Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bottom sheet component (Image Settings) #529

Merged
merged 9 commits into from
Feb 1, 2019
Merged

Bottom sheet component (Image Settings) #529

merged 9 commits into from
Feb 1, 2019

Conversation

etoledom
Copy link
Contributor

This PR updates the gutenberg reference to test the BottomSheet component, implemented in Image Settings.

bottom-sheet

For instruction on how to test, refer to the gutenberg side PR: WordPress/gutenberg#13612

@etoledom etoledom added the [Type] Enhancement Improves a current area of the editor label Jan 31, 2019
@etoledom etoledom added this to the Beta milestone Jan 31, 2019
@etoledom etoledom self-assigned this Jan 31, 2019
@etoledom etoledom requested a review from Tug January 31, 2019 08:46
@etoledom etoledom mentioned this pull request Jan 31, 2019
Merged
Tug
Tug approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
(Don't forget to update the gutenberg ref before merging ;))

@etoledom etoledom merged commit ae167fa into develop Feb 1, 2019
@etoledom etoledom deleted the issue/bottom-sheet-component branch February 1, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tug Tug Tug approved these changes

Assignees

@etoledom etoledom

Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
Beta
Development

Successfully merging this pull request may close these issues.
2 participants
@etoledom @Tug