-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script for running pnpm
commands in Jetpack repo
#5667
Conversation
7bd6610
to
ccdf1ba
Compare
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
Setting the PR back to draft because I'm getting the following error when trying the build a Jetpack plugin with the new script.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
The fix provided in #5689 should address this issue 🎊 . |
ccdf1ba
to
dcfb467
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is ready to review again 🎊 .
# Install dependecies of Jetpack plugin | ||
pushd projects/plugins/jetpack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the future incorporation of the VideoPress package, seems more practical to install the dependencies from the root level.
# Revert to Gutenberg node version | ||
nvm use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed when running this script that after the execution, I was on a different node version. Hence, I added that nvm
changes the node version to the one recommended in Gutenberg/Gutenberg Mobile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work! I was able to run npm i
successfully and I was also able to generate the bundles and strings correctly 🚀
The idea behind adding this script is to allow running any command in the Jetpack repo. Currently, we only run
install
command to install the dependencies. In the next PR, to solve the issue mentioned here, we'll run the script to build the VideoPress package.To test:
npm i
.PR submission checklist: