[Translation pipeline] Build VideoPress package to extract localization strings #5668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
force-pushed
the
add-run-jetpack-command
branch
from
ccdf1ba
to
dcfb467
Compare
fluiddot
force-pushed
the
i18n-build-videopress-plugin
branch
from
44595da
to
ccd2380
Compare
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
dcalhoun
approved these changes
Apr 26, 2023
Co-authored-by: David Calhoun <github@davidcalhoun.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR:
pnpmcommands in Jetpack repo #5667Fixes the issue mentioned here.
The translation pipeline needs to extract the localization strings used in the web version to identify which ones are only used in the native version. The latter is added to the localization strings files to be translated along with the rest of the strings of the host apps. For this reason, since we'll incorporate the VideoPress block, we need to build the VideoPress package.
Additionally, the section, related to adding a new i18n domain for a plugin, has been updated in the
READMEto reflect the recent changes after introducing the VideoPress package.To test:
jetpack/projects/packages/videopress/build.npm run bundle.bundle/ios/GutenbergNativeTranslations.swiftandbundle/android/strings.xml).PR submission checklist: