Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable npm configuration parameter engine-strict when installing dependencies of Jetpack #5689

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

fluiddot
Copy link
Contributor

This PR disables the engine-strict parameter in Jetpack's .npmrc file as we can't ensure that the node version used by npm to check the engines parameter is the expected one. The parameter is reverted back after installing the dependencies.

NOTE: This change is a temporary workaround until we find a better solution to #5688.

To test:

  1. Checkout the last commit from trunk branch of the Jetpack repository.
  2. Run command npm install.
  3. Observe that the command succeds.

Additionally, the fix has been also applied to #5687 in order to check that CI jobs succeed 🟢 .

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added [Type] Bug Something isn't working Tooling labels Apr 20, 2023
@fluiddot fluiddot added this to the 1.94.0 (22.3) milestone Apr 20, 2023
@fluiddot fluiddot self-assigned this Apr 20, 2023
@fluiddot fluiddot requested review from jhnstn and SiobhyB April 20, 2023 15:09
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fluiddot, reviewed this, as well as the discussion on Slack, and confirmed npm install works perfectly with these changes applied. Thank you for getting to the bottom of this one 🙇‍♀️

@fluiddot fluiddot merged commit e53664c into trunk Apr 20, 2023
2 checks passed
@fluiddot fluiddot deleted the jetpack-install-deps-disable-engine-strict branch April 20, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tooling [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants