Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Listen for post save events #5663

Merged

Conversation

wpmobilebot
Copy link
Collaborator

@wpmobilebot wpmobilebot commented Apr 12, 2023

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 12, 2023

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@SiobhyB SiobhyB requested review from fluiddot and jhnstn April 17, 2023 22:25
@SiobhyB SiobhyB requested a review from fluiddot April 18, 2023 13:59
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Automattic/jetpack#30131 (review).

I noticed that several CI jobs are failing due to an incompatibility with the node version (example). Therefore, it would be great to solve it before merging this PR. Note that this is also happening in #5682.

@fluiddot
Copy link
Contributor

@SiobhyB I created this PR to address the issue that is causing CI jobs to fail.

@SiobhyB SiobhyB enabled auto-merge April 20, 2023 16:58
@SiobhyB SiobhyB merged commit 62aa47f into trunk Apr 20, 2023
@SiobhyB SiobhyB deleted the version-toolkit/gutenberg/rnmobile/feat/listen-for-save-events branch April 20, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VideoPress block: Limit synchronization of block attributes to when post has just been saved
3 participants