Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shortcuts Window demo #31

Open
sonnyp opened this issue Dec 14, 2023 · 5 comments
Open

Add Shortcuts Window demo #31

sonnyp opened this issue Dec 14, 2023 · 5 comments
Labels
good first issue Good for newcomers

Comments

@sonnyp
Copy link
Contributor

sonnyp commented Dec 14, 2023

https://docs.gtk.org/gtk4/class.ShortcutsWindow.html

@sonnyp sonnyp changed the title Shortcuts Window Add Shortcuts Window demo Jan 28, 2024
@sonnyp sonnyp added the good first issue Good for newcomers label Jan 28, 2024
@sonnyp
Copy link
Contributor Author

sonnyp commented Feb 6, 2024

All demos should be available in JS
So that's a good starting point.

Look at other similar demos are done such as Preferences Window

@sonnyp
Copy link
Contributor Author

sonnyp commented Feb 6, 2024

You can start in Python, but the demo won't be accepted unless it has a JavaScript version

@imhemish
Copy link
Contributor

imhemish commented Mar 1, 2024

All demos should be available in JS So that's a good starting point.

Look at other similar demos are done such as Preferences Window

I don't get why this needs to be in JS, there is no dynamic functionality in Shortcuts Window. In my opinion, it should just be a pure blueprint implementation.

@sonnyp
Copy link
Contributor Author

sonnyp commented Mar 1, 2024

Because the demo needs a button to open the ShortcutsWindow

@sonnyp
Copy link
Contributor Author

sonnyp commented Mar 16, 2024

"Preferences Dialog" can be used as inspiration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants