Port demos to GNOME 46 #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
force-pushed
the
46
branch
2 times, most recently
from
0bb9ee6
to
801c76c
Compare
sonnyp
requested review from
theCapypara,
Hofer-Julian and
lw64
as code owners
Excluding Rust demos, right? |
| @@ -29,7 +28,7 @@ fn on_button_clicked() { | |||
|
|
|||
| dialog.add_link( | |||
| "Documentation", | |||
| "https://gnome.pages.gitlab.gnome.org/libadwaita/doc/1.4/class.AboutWindow.html", | |||
| "https://gnome.pages.gitlab.gnome.org/libadwaita/doc/1.5/class.AboutDialog.html", | |||
There was a problem hiding this comment.
Suggested change
| "https://gnome.pages.gitlab.gnome.org/libadwaita/doc/1.5/class.AboutDialog.html", | |
| "https://world.pages.gitlab.gnome.org/Rust/libadwaita-rs/stable/latest/docs/libadwaita/struct.AboutDialog.html", |
There was a problem hiding this comment.
hmm I feel like this should be addressed globally
could you file a PR or issue for updating all urls in Rust code?
There was a problem hiding this comment.
Sure, if you prefer that
lw64
approved these changes
Feb 11, 2024
Hofer-Julian
approved these changes
Feb 12, 2024
theCapypara
approved these changes
Feb 12, 2024
theCapypara
reviewed
Feb 12, 2024
Diego-Ivan
reviewed
Feb 21, 2024
There was a problem hiding this comment.
This has similar issues with the Dialogs demo (addressed in #107), but I can take care of that once this one is merged 👍
Diego-Ivan
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68 and more, see commits
You'll need Workbench Devel/main if you want to test this.
CI fails here because it's using Workbench 45
but I tested locally with
make ciwith Workbench 46beta workbenchdev/Workbench#896 which runs over all demos