dialogs: Fixes and Improvements to Vala demo #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including: * Use C-Style casting * Use string formatting in console logs * Use `async`-`yield` instead of signal callbacks * Initialize objects with properties * Add missing comments from the JS demo * Small fixes for confirmation and advanced dialogs
lw64
approved these changes
Feb 21, 2024
|
Can you document the missing guidelines in https://github.com/workbenchdev/demos/blob/main/STYLEGUIDE.md#vala ? |
|
Sure, just sent a PR with the missing ones :) |
This was referenced Feb 21, 2024
Merged
|
Could you solve conflicts? Sorry the Dialogs demo was renamed. |
…os into diego-ivan/dialogs-vala
Diego-Ivan
requested review from
theCapypara,
Hofer-Julian and
sonnyp
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including:
async-yieldinstead of signal callbacks (as in the JS demo)