Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for Simulation actor #15

Closed
PetrosPapapa opened this issue Aug 4, 2020 · 1 comment
Closed

Unit tests for Simulation actor #15

PetrosPapapa opened this issue Aug 4, 2020 · 1 comment
Labels
code improvement requires improvements in the code such as cleaning up or commenting/documentation

Comments

@PetrosPapapa
Copy link
Member

Follow the test patterns for the Coordinator to create unit tests for the interaction with the Simulation actor.

  • Use SingleTaskSimulations or create dummy simulations.
  • Fake a Coordinator (directly or through a probe).
  • Send messages to the dummy simulations and see if they respond as expected.

Flow simulations (FlowSimulationActor) from #7 / #14 should be tested like this as well.
@PetrosPapapa PetrosPapapa added the code improvement requires improvements in the code such as cleaning up or commenting/documentation label Aug 4, 2020
@PetrosPapapa
Copy link
Member Author

Version 0.6 has brand new scalamock tests. Flow tests still require updating, but this will do for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code improvement requires improvements in the code such as cleaning up or commenting/documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PetrosPapapa