Move focused window to adjacent Workspace and switch to that Workspace#186
Conversation
… workspace and switch to it
Also added keybindings for above mentioned:
Alt+Shift+Left :: Move Focused Window And Switch To Previous Workspace
Alt+Shift+Right :: Move Focused Window And Switch To Next Workspace
|
I haven't looked too closely at the code, but we just merged this PR here today: Would you consider that an adequate solution to your needs, or does your PR target other use-cases? I'm in no way trying to discourage you from contributing, but just trying to be sure we don't merge duplicate functionality. |
|
Thanks for your reply, @josteink! I had a look at #163, and if I'm not mistaken, that one relates to the shuffling/cycling of monitors, whereas this (#186) is meant to streamline moving around the focused window between workspaces on the same monitor. However, it seems that the key bindings are overlapping, so some new ones will be needed if they are to be included as default. A suggestion would be |
|
To be honest, since I was able to go full Linux on my workstation at work, I'm no longer really using Windows to such an extent that I need/use workspacer anymore. I just still hang around and do code-review and stuff because I'm very much sympathetic to the goals of the project 😊 So that means @rickbutton or some other actual regular users will have to voice opinions about the ergonomics and preferences for new key-bindings. |
| IWorkspace GetPreviousWorkspace(IWorkspace currentWorkspace); | ||
| int GetNextWorkspaceIndex(IWorkspace currentWorkspace); | ||
| int GetPreviousWorkspaceIndex(IWorkspace currentWorkspace); | ||
|
|
There was a problem hiding this comment.
Since GetNextWorkspaceIndex and GetPreviousWorkspaceIndex are being added, I think it would make sense to expose a GetWorkspaceIndex(IWorkspace workspace) method too.
There was a problem hiding this comment.
I agree. I updated the default key bindings and added GetWorkspaceIndex(IWorkspace workspace) in 5de1d6c.
There was a problem hiding this comment.
Awesome! Would you be able to use GetWorkspaceIndex in GetNextWorkspaceIndex and GetPreviousWorkspaceIndex too?
…t with those recently defined in workspacer#163 added `int GetWorkspaceIndex(IWorkspace workspace)` to the `IWorkspaceContainer` as suggested by @dalyIsaac
…` and `GetPreviousWorkspaceIndex` to reduce code duplication
|
LGTM. Thanks for the patch! Feel free to send more PRs in the future. |
3 participants
Hi, first time making a pull request, so please do point out if this PR is not up to standard.
What I'm proposing here is adding functionality to move the focused window to an adjacent workspace and "follow it" in the sense that you switch to the workspace where the focused window now resides.
As such, it is just a "shorthand" for placing a window in the
n'th workspace withAlt+Shift+{n}and then switching to it withAlt+{n}.I added the following key bindings for the above mentioned, for which I could not find any conflicts and I believe are quite intuitive as an extension of the original ones:
Alt+Shift+LeftMove Focused Window To Previous Workspace And Switch to ItAlt+Shift+RightMove Focused Window To Next Workspace And Switch to It