Skip to content
This repository has been archived by the owner on Apr 7, 2024. It is now read-only.

Redundant steer to "visit review" when duplicate module review is entered #72

Closed
ruthsykes opened this issue Oct 25, 2020 · 1 comment · Fixed by #79
Closed

Redundant steer to "visit review" when duplicate module review is entered #72

ruthsykes opened this issue Oct 25, 2020 · 1 comment · Fixed by #79
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ruthsykes
Copy link

Journey:

  1. Already reviewed ITP1
  2. Go to Courses and select ITP1 again (and fill in other boxes with valid input)
  3. Hit Submit
  4. My original review is presented to me (not the new review), however this page also has "You have already reviewed this course. Would you like to edit it? Visit review" link on it which is redundant, as I am already there.

Suggest after hitting Submit, the new review remains on the page, in case the user has selected the wrong module by accident. Then their text isn't lost.

@BlairCurrey
Copy link
Collaborator

BlairCurrey commented Oct 25, 2020

Thanks for the suggestion Ruth. I agree with your suggestion. In addition I think we should flash a message indicating they have already reviewed the course and add a link to the edit page.

For some more context, the visit review link is hardcoded into the flash message in the editreview.html template. It will always show a link to the review regardless of the message. This was originally implemented so that you would have a link after editing so that you could see the review - however, it's not always that relevant (such as this situation). Ideally it should probably be part of the message sent from the server (only included when relevant) but it wasn't clear to me how to ensure it rendered as link instead of text.

@ankush ankush added the enhancement New feature or request label Oct 25, 2020
@ankush ankush added this to the release milestone Oct 25, 2020
@BlairCurrey BlairCurrey self-assigned this Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants