Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q and R symbol is misrepresented? #22

Closed
daun-io opened this issue Sep 11, 2020 · 1 comment
Closed

Q and R symbol is misrepresented? #22

daun-io opened this issue Sep 11, 2020 · 1 comment

Comments

@daun-io
Copy link

daun-io commented Sep 11, 2020

I'm kinda new to this kalman filter concept and after few surveys on the web and now I'm really confused about the symbol's representation made in this repository.
I think the measurement noise symbol that is described as Q should be R and process noise symbol that is described as R should be Q.

You can see many of the references are referring Q as a process noise and R as a measurement noise.

https://github.com/rlabbe/filterpy/blob/master/filterpy/kalman/kalman_filter.py
http://www.swarthmore.edu/NatSci/echeeve1/Ref/Kalman/MatrixKalman.html
https://www.diva-portal.org/smash/get/diva2:1041201/FULLTEXT01.pdf
https://arxiv.org/ftp/arxiv/papers/1702/1702.00884.pdf
https://en.wikipedia.org/wiki/Kalman_filter#Underlying_dynamical_system_model

Update*
I saw the comment that you leaved at your blog and I'm still not sure about which definition is closer to the original.
image

I'll leave a pull-request if needed, Thanks :)

@daun-io daun-io changed the title Q and R symbol is misrepresented Q and R symbol is misrepresented? Sep 11, 2020
@wouterbulten
Copy link
Owner

Hi, when I wrote this library I encountered the same issue. As I said in the comment, I followed the same definition as used in Thrun et al. and this is also used in the paper where this library was used (https://ieeexplore.ieee.org/abstract/document/7471364/).

To keep it consistent, I will follow the original definition. In the end, it's a matter of opinion. The workings of the library are the same, regardless of the naming of those variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants