Stricter typescript rules

[lucca-fonte]

I saw in #1 v1 Roadmap section that the Stricter typescript rules is available. If no one is working on it I'm interested in tackling this 😃. @wovalle can you elaborate about this issue?

[wovalle]

Hey, thanks for the interest!

I haven't digged too much into it but my idea was to try to remove as much rules as I can from the tsconfig file. Ideally be able to run fireorm with strict: true but it wouldn't be entirely possible

[lucca-fonte]

Ok. I will play around with the strict rule family and see what we can do.

[lucca-fonte]

Working on the strict migration I realized how much of a daunting task that is 😅. Do you guys think it would be possible to take an incremental approach to this migration, something similar to this comment?

[wovalle]

That sounds good! I'm working in a PR that will get rid a lot of errors, might be a good idea working after I'm done with it 😅
#165

[wovalle]

Update: merged #165

[lucca-fonte]

Addressing this comment. I'm thinking of doing on a folder-by-folder manner. With that in mind, here is the work pending:

• src/Batch/
• src/Errors/
• src/Transaction/
• src/AbstractFirestoreRepository.ts
• src/BaseFirestoreRepository.ts
• src/BaseRepository.ts
• src/helpers.ts
• src/MetadataStorage.ts
• src/QueryBuilder.ts
• src/utils.ts

To make a folder or file strict we just need to add it to the include cause in the inner tsconfing.json and fix the errors. After all the files are migrated we can remove the inner tsconfig and add the strict option to the outer tsconfig

[lucca-fonte]

Will work on the Batch migration now 😄