Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBC Warrior Simulator - Battle Shout Buff Uptime #739

Open
JoeyWButler opened this issue Apr 23, 2022 · 2 comments
Open

TBC Warrior Simulator - Battle Shout Buff Uptime #739

JoeyWButler opened this issue Apr 23, 2022 · 2 comments
Labels
wontfix This will not be worked on

Comments

@JoeyWButler
Copy link

Describe the bug
The normal Battle Shout does not appear under "Buffs", and neither displays the uptime under "Timeline".

To Reproduce
Steps to reproduce the behavior:

  1. Simulate without "Precast with Sapphire" or "Precast with T2".
  2. Click "Buffs" and "Timeline".

Expected behavior
A snapshot Battle Shout does appear under "Buff" and "Timeline", reflecting and displaying accurate uptimes. A normal Battleshout does not.

Sim Links and Screenshots

Screenshot of "Buffs" and "Timeline":
https://imgur.com/a/pizYfTm

Simulator settings:
https://wowsims.github.io/tbc/warrior/#eJztUs9LVFEUnu+8eeOdm8VltLgNKPYWYUHwnsOAQuBtl4vgtRFXYkFR0CZXk6spZ3B05Y+FZouS/oGhRTwKRAo0MKtFixHtJ9ZGKArCxaTjve8y/0HLzr2c79zvO/ece+By6qaMZKgCC6BHoG4UqAgngrsCys6k7iEV3rpy59ooaxHp7DK4EBv7kJUdeKn7+/haB0+KtweGH/8NWfui+Y16zDPxukzy/STxNtH4BfnyOby01uzW8vIBZH3TRFt/Idd1YqtY3LUFTMZRcVeX/PQdnmPqCbE6TnJvWyesf8Bm3PnPjvG1Mmm/9s3Ej3+agvMfIR+USEdLuvPDqlFelMnrqFKySG6F8IqSn8mtkVtwaqBpBwsOzr6jxH/7pzbGGBQk9WL0Ej8vUMAZKwyowAZ9qi/G4qC6YJl2NRDjylUV4gZGMIRpIJPIHkk3MyWm4OXyvp8P/CDn9/jBOT+vlyYMBD3GBflFhFzwY2zyRFejaeAud1hphKd4ki1NkMH47xh8+sRiySKrR8fj89wze63R7oX2EYlhdar53JNRZ3n3cvSmP5OzYm+kJGVOCz16BSgCFymkIT1JATevx/aj/7adcVYdAqYOj5M=

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Firefox
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@jimmyt857
Copy link
Contributor

It's not shown because internally we don't actually represent the aura anywhere, we just give fixed stats for battle shout.

Going to leave this open as a TODO, there are quite a lot of other buffs we dont show uptime for.

@jimmyt857
Copy link
Contributor

Migrating to wrath in the next week so this won't be fixed.

@jimmyt857 jimmyt857 added the wontfix This will not be worked on label Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants