Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugs] DK Tank Sim Crypt Fever and Ebon Plaguebringer Detection #3580

Open
NuptupTDOW opened this issue Aug 31, 2023 · 0 comments
Open

[Bugs] DK Tank Sim Crypt Fever and Ebon Plaguebringer Detection #3580

NuptupTDOW opened this issue Aug 31, 2023 · 0 comments

Comments

@NuptupTDOW
Copy link

Describe the bug
When simming for an Unholy>Blood Hybrid Tank spec, the viability of Death Strike relies on having a 3rd disease active on the target to have the same healing per Death Strike as a Deep Blood spec DK with Improved Death Strike. Normally this is attained by putting 3/3 into crypt fever and 3/3 into ebon Plaguebringer if your raid needs the buff provided by ebon Plaguebringer, or if that buff is provided by a different class you put a single point into Crypt Fever to give you a 3rd disease on the target to get the extra 5% of max health per Death Strike. There are currently 2 issues with this interaction in the DK Tank sim. I am combining them into one post because I believe the solution should be the same for both issues.

Issue One
Whether you have 3/3 Crypt Fever AND 3/3 Ebon Plaguebringer, or 1/3 Crypt Fever only, no combination of these results in Death Strike registering a 3rd disease being applied to the target and increasing it's healing done. You can see Ebon Plaguebringer being applied in the bottom portion of the timeline in the Sim, but it doesn't have any affect on the health received from Death Strike.

Issue Two
If you have 3/3 Ebon Plaguebringer, it will show the debuff in the bottom of the timeline. If you have 0/3 Ebon Plaguebringer and 1/3, 2/3, or 3/3 in Crypt Fever, it will not show Crypt Fever in the Timeline at all and will only show Ebon Plaguebringer, which shouldn't be there at all.

To Reproduce
Steps to reproduce the behavior:

  1. Go to DK Tank sim, restore defaults, remove all Raid Buffs in Settings, put 36 points into unholy tree and select 1/3 crypt fever.
  2. Run a sim in the Results>Timeline and at the top of the Timeline report, find an instance where the sim landed a death strike while not being at maximum health and write down that value. We will use this to compare against later to provide evidence for Issue One.
  3. Next scroll to the bottom and see that there is Ebon Plaguebringer (Which there shouldn't be), and no Crypt Fever (Which there should be). This is evidence of Issue Two.
  4. Return to the Talent tree and select 3/3 Crypt Fever and 1,2,3/3 Ebon Plaguebringer and repeat the sim iteration from the timeline report.
  5. Check for a death strike again and confirm that the healed value is the same as in step 2, which proves that talenting into crypt fever OR ebon Plaguebringer results in the same amount of healing being provided (Currently no bonus at all.)
  6. Change the talents to the preset Blood talents that include Improved Deathstrike and run an iteration in the timeline. Check for a death strike as in step 2 and step 5 and compare this value to the values from those steps. There should be a 5% max health increase from before.

Expected behavior
Improved Death Strike has a flat 50% increase to Death Strike healing resulting in 10+5%, or 5+2.5% for 15/7.5% depending on one or 2 diseases applied. For Unholy Tanking, Either Crypt Fever OR Ebon Plague Bringer should result in a 10% max health heal with a single disease applied, or a 15% when both primary buffs are applied, because applying either of the primary buffs automatically applies Crypt Fever/Ebon Plaguebringer, so 1 disease is 2, and 2 is 3.

Desired Resolution
1: Crypt Fever and Ebon Plaguebringer should be separated to not both apply Ebon Plaguebringer on the assumption that the DK will be taking 3/3+3/3 on both talents. This likely should be checked for Dps sim as well.
2: Crypt Fever and Ebon Plaguebringer should each individually be capable of granting an additional 5% healing from a successful Death Strike, however Crypt Fever should still NOT be applied when Ebon Plaguebringer overrides it. This should also only heal the DK when it is their application of the debuff, not someone else's. This means that there should be a visible Crypt Fever in the Timeline, even if a different raid member is providing Ebon Plaguebringer, as the DK Tank's Crypt fever is still active on the enemy even if it does nothing to them except provide additional healing to the DK.
3:

Sim Links and Screenshots
[If applicable, add links to your sim settings or screenshots to help explain your problem.]
Below is a link to my Sim Export. I have added preset talent trees and raid settings to get the 3 tests quickly. Feel free to ignore them and do it yourself if you want to confirm nothing is faulty with my set-ups.
(https://wowsims.github.io/wotlk/tank_deathknight/#eJztVl1oE1kUnnvuJE6O1k6vUcarjnFAKIHCJKlFZdfJ+uKjtUUQEdGH+iAiap/0yRV/sP5URLFGsUWl6w/bhX0xsBS0KrRiQaH1F6G2auvPbguLUHF32Tt/6dSmGqu+eQiXe75zvu+ce3NmEpSWSotBJUzi76fuIuHKTeu312xTiIq8k2CxemEAtGbdCJ+/Do2NgBH11z4waHsWcIp6ScQO6r6X7QPt+GyD3nO85gEwwoJhk1C90gNanW4QCYvUXwTrmG7IgiWJAoNCLyL27geZmnkG2l9zglixer4ftKaZRtgDImqj34WsHu611xc99nqz385+Ijq5xHPZkgg86AFDUWSzqJKuomfhLeBVkL7bFxkzP5exQ9oFCsoKiREu1RG9rMw0FyRNM2UuEEvSWVMJM5FMiDXVSzTlz+egHukC7UwXxE52Q2lDN5j1XTBA5CEyKUMiJRscu2e1walIEyEYRYWHRYl978QXjmJXljBrcZqHnmijxiQMIS1L1TKZw2KJZQg/QdgxguHlW2o212xjbub7TsqQCwXl5700Rrz97sC+bszeZd75G0Zlj+gVsnvYBwEszZdgOUsii6uKzOgjInGn/XJzPhYZkzHyO7FTM50QdK/9Rh2Fhn+BTefTfFi4Nmw/JBMU9hTsAoUqCEq+1oQw0/nsMewKc74Tv/7PR+Pq6ab88XKP3y/4c/gsLIkXK2FGb4m4gBGSphMe/IMyjc/AKQaikrSRKy00d+uca4FIs4iMzMES/gMmuYkz4lFRWNkY4CKkakfhzSO4e+hDlF0m/ALBU4Q3EIyzUucAIRZ6RUABLg6AxAxi1McKyJXHyaUfyx2LJQKzW8HLg2pH4YPKMgvVQa5CKneDC3nFhzyahwc+b+R+Y1wPsojHGv3EOXWGXwNby9dgFat0GNQ9hcdIBDHIg9E8WO4G/Oc43wgtdEeofw/NtSJeK7lUbxqdVG8Yh/+DdmgnWUIekWhkpW2NrekS950I6Vg4A5JxgEYcf+cGPxJNz8yctK3DWuQid6x5/vsu+Rhi1Voo/o1/xkr3p7+GzM6OG5/Qqf4qdSZi7t22DqZ/cv1hax2pcv4gzN3zekVW77ZSjvVZbnzI+tKKWd0WbrG2/oj3z215br1ZYSN3rac7oi3Lnt6yqpyE9lx8PB13Oi5ao/2Xlj8jrl6v57+w6tvelq6p751w/27fZwrmM7Pztm1KulDG6nH+UgyNe/f/Ax8UbAE=)

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants