Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract config set --add to config add #46

Open
danielbachhuber opened this issue Feb 17, 2018 · 4 comments
Open

Abstract config set --add to config add #46

danielbachhuber opened this issue Feb 17, 2018 · 4 comments

Comments

@danielbachhuber
Copy link
Member

config set --add is a deviation from our standard syntax. Typically, set and add are two separate operations (e.g. option set vs. option add, and cache set vs. cache add).

It'd be better to abstract config set --add to config add.

We may also consider a config update, which would add the constant if it didn't exist, or update it if it did.

@danielbachhuber
Copy link
Member Author

@wp-cli/committers Does this seem reasonable to you?

@gitlost
Copy link
Contributor

gitlost commented Feb 17, 2018

Seems reasonable to me.

@frankiejarrett
Copy link
Contributor

Agreed.

Using the same CRUD verbs as the option command seems the most straightforward to me.

wp config get
wp config add
wp config update
wp config delete

@schlessera
Copy link
Member

Hehe, I think I started out with wp config add & wp config update, but then later changed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants