Document what wp db check doesn't do; provide suggestions for next commands #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlk
commented
Oct 26, 2023
danielbachhuber
requested changes
Nov 1, 2023
src/DB_Command.php
Outdated
| @@ -258,6 +261,8 @@ public function check( $_, $assoc_args ) { | |||
|
|
|||
| WP_CLI::debug( 'Associative arguments: ' . json_encode( $assoc_args ), 'db' ); | |||
| WP_CLI::success( 'Database checked.' ); | |||
| WP_CLI::log( 'To check whether the WordPress DB tables are installed: wp core is-installed', 'db' ); | |||
| WP_CLI::log( 'To check whether the WordPress DB tables need to be updated: wp core update-db --dry-run', 'db' ); | |||
There was a problem hiding this comment.
We generally don't render any output after WP_CLI::success().
For this particular problem, I'd prefer to remove these WP_CLI::log() statements and simply keep to the command doc changes.
danielbachhuber
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
wp db checkdoesn't check anything WordPress-specificWhy
#148